This module provides a user specific language functionality. There are two checkboxes on settings page in admin panel

- show language option at time of registration
you can choose one language at time of registration or when you modify profile.

- show language option at time of login
you can choose one language at time of login. This will update in your profile at time of successful login.

http://drupal.org/sandbox/lalit774/1589340

Comments

lalit774’s picture

Status: Active » Needs review
pgogy’s picture

Hello

Ventral (ventral.org) reports the following coding standards issues - http://ventral.org/pareview/httpgitdrupalorgsandboxlalit7741589340git

You might want to install Drupal Code Sniffer and Drupal coding standards

Also

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

The following git branches do not match the release branch pattern, you should remove/rename them. See http://drupal.org/node/1015226

README.txt is missing, see the guidelines for in-project documentation.
The "?>" PHP delimiter at the end of files is discouraged, see http://drupal.org/node/318#phptags

./user_specific_language.admin.inc - Remove all old CVS $Id tags, they are not needed anymore.

staticred’s picture

This is already pretty much accomplished by Drupal's internationalization, isn't it, at least in terms of saving language states between authenticated sessions?

Not sure what this module would add, aside from a way to specify your default language on registration.

staticred’s picture

Also, this project might be too short for effective review.

See http://groups.drupal.org/node/195848

sanchi.girotra’s picture

1.There is still a master branch, make sure to remove it. See http://drupal.org/node/1127732
The following git branches do not match the release branch pattern, you should remove/rename them. See http://drupal.org/node/1015226
remotes/origin/6.x-1.0
2.Please check an automated review of your code here : http://ventral.org/pareview/httpgitdrupalorgsandboxlalit7741589340git-userspecificlanguage.
3.And Through Coder your project have 43 normal warnings, 5 minor warnings mostly related to indentation.

krylov’s picture

Please consider the following suggestions for user_specific_language.module:
General:
1. use leading underscores for function names you use only in the module
2. what is the point of putting 'user_specific_language_settings_form' in an .inc file rather than in the .module file? You might as well keep in the .module file.

Per line:
1. use two spaces for indentation
2. linese 22 can be rewritten as $perm = array('access user specific language');
3. line 32 do not use caps in function names
4. line 34 space missing between ) and {
5. line 65 do not use caps in function names
6. line 91 indicate this is a hook implementation
7. line 93 space missing between ) and {
8. line 95 space missing before and after the = sign
9. line 96 same as above
10. lines 102-105. Is this a tester function? If so, delete or at least comment it out.

krylov’s picture

Status: Needs review » Needs work
klausi’s picture

Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.