Patch coming soon, see also #1513210: Meta: Start converting module provided classes to PSR-0

CommentFileSizeAuthor
#13 1591928-language-tests-13.patch101.05 KBaspilicious
#6 1591928-language-tests-6.patch101.04 KBaspilicious
#3 1591928-language-tests-3.patch101.03 KBaspilicious
#1 1591928-language-tests-1.patch101.03 KBaspilicious

Comments

aspilicious’s picture

aspilicious commented
Status: Active » Needs review
StatusFileSize
new 1591928-language-tests-1.patch101.03 KB

Let's try this

Status: Needs review » Needs work

The last submitted patch, 1591928-language-tests-1.patch, failed testing.

aspilicious’s picture

aspilicious commented
Status: Needs work » Needs review
StatusFileSize
new 1591928-language-tests-3.patch101.03 KB

Hopefully this one is better

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue tags: +sprint, +language-base

Adding sprint tag for D8MI.

Status: Needs review » Needs work

The last submitted patch, 1591928-language-tests-3.patch, failed testing.

aspilicious’s picture

aspilicious commented
Status: Needs work » Needs review
StatusFileSize
new 1591928-language-tests-6.patch101.04 KB

This one should pass

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Reviewed & tested by the community

I did not review the tests line by line, trust @aspilicious that only the required changes were done. Since we are doing other test cleanup too (eg. #1561004: Many tests still reference locale although they only need language module) and this is a pain to reroll, let's get this in sooner than later.

Tor Arne Thune’s picture

Tor Arne Thune commented

+1 to the RTBC, after having reviewed the patch.

robloach’s picture

robloach
he/him
commented

core/modules/language/lib/Drupal/language/Tests/ is the correct location for all these. Namespaces correct, definitions are right. Looks good.

aspilicious’s picture

aspilicious commented
Issue tags: -D8MI, -sprint, -PSR-0, -language-base

#6: 1591928-language-tests-6.patch queued for re-testing.

aspilicious’s picture

aspilicious commented

#1: 1591928-language-tests-1.patch queued for re-testing.

Status: Reviewed & tested by the community » Needs work
Issue tags: +D8MI, +sprint, +PSR-0, +language-base

The last submitted patch, 1591928-language-tests-6.patch, failed testing.

aspilicious’s picture

aspilicious commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new 1591928-language-tests-13.patch101.05 KB

/me hates rerolls

catch’s picture

catch
he/him
Primary language English
commented

Committed/pushed to 8.x, thanks!

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue tags: -sprint

Superb, thanks all.

Automatically closed -- issue fixed for 2 weeks with no activity.