upgrade path: uc_payment_receipts data field not null (Order always pending)

Interesting, thanks for the analysis.

Manual test case for this would be install D5/Ubercart 1.x, upgrade to D6/UC2, upgrade to D7/UC3, then install http://drupal.org/project/schema and see what it reports.

There were a lot of schema problems in the D5 version of Ubercart, so I'm quite certain that there are some schema changes over the past four years that weren't handled by update functions. The question is what to do at this point, since D5 is no longer supported so we no longer support the D5->D6 upgrade which is where the vast majority of these problems would arise.

You can, of course, go directly into your database and change the schema manually if you find a problem like this. IMO that's the recommended course of action, and it's a small price to pay for such a big upgrade! I don't think it's appropriate to add a hook_update_7xxx() to change the schema if the D7 schema is the same as the D6 schema, which is the case here. And I'm not going to add a hook_update_6xxx() to deal with D5->D6 upgrades at this point. We simply don't have the manpower or time (all volunteer) to support an obsolete version of Drupal and Ubercart.

Did a quick test on an old D5 database I had lying around, converting it to D6 and running Schema against it. Lots of differences in default values which I think we can safely ignore, which leaves the following:

uc_payment_receipts
column data - difference on: not null
declared: array('description' => t('TODO: please describe this field!'), 'type' => 'text')
actual: array('description' => t('TODO: please describe this field!'), 'type' => 'text', 'not null' => TRUE)

uc_orders
column host - difference on: length
declared: array('description' => t('TODO: please describe this field!'), 'type' => 'varchar', 'length' => 255, 'not null' => TRUE, 'default' => '')
actual: array('description' => t('TODO: please describe this field!'), 'type' => 'varchar', 'length' => '16', 'not null' => TRUE, 'default' => '')

uc_order_admin_comments
column message - difference on: not null
declared: array('description' => t('TODO: please describe this field!'), 'type' => 'text')
actual: array('description' => t('TODO: please describe this field!'), 'type' => 'text', 'not null' => TRUE)

uc_order_comments
column message - difference on: not null
declared: array('description' => t('TODO: please describe this field!'), 'type' => 'text')
actual: array('description' => t('TODO: please describe this field!'), 'type' => 'text', 'not null' => TRUE)

uc_order_log
column changes - difference on: not null
declared: array('description' => t('TODO: please describe this field!'), 'type' => 'text')
actual: array('description' => t('TODO: please describe this field!'), 'type' => 'text', 'not null' => TRUE)

uc_order_products
column data - difference on: not null
declared: array('description' => t('TODO: please describe this field!'), 'type' => 'text')
actual: array('description' => t('TODO: please describe this field!'), 'type' => 'text', 'not null' => TRUE)

uc_products
indexes nid: missing in database

uc_store_footers
column message - difference on: not null
declared: array('description' => t('TODO: please describe this field!'), 'type' => 'text')
actual: array('description' => t('TODO: please describe this field!'), 'type' => 'text', 'not null' => TRUE)

If uc_payment_receipts is causing a problem we should fix it, the rest I think we can leave except perhaps we should ensure there is an index on uc_products.nid.

Patch for the uc_payment_receipts issue in D6, will need forward porting to D7 for sites that have already upgraded.

Committed. If anyone needs this in D7 please reopen.