code block missing braces [#1594608]

  if ($setting == 'all') return $popup_settings;

The block for the 'if' statement needs braces, needs to be on its own line. Coder review will notify you of this and other problems.

Comment	File	Size	Author
#4	eu_cookie_compliance-1594608.patch	2.12 KB	rsvelko
#3	eu_cookie_compliance-1594608.patch	1.84 KB	rsvelko

Comments

Miszel commented 22 May 2012 at 18:38

Priority:

Normal

» Minor

Miszel commented 23 May 2012 at 00:14

I have marked it as minor as it does not affect the functionality of this module.

rsvelko commented 25 May 2012 at 12:30

Status:

Active

» Needs review

Status	File	Size
new	eu_cookie_compliance-1594608.patch	1.84 KB

here is a patch that solves these

rsvelko commented 25 May 2012 at 12:32

Status	File	Size
new	eu_cookie_compliance-1594608.patch	2.12 KB

oops. Forgot sth - the new patch.

Miszel commented 25 May 2012 at 13:27

Category:

bug

» task

Thank you. It is very much appreciated. Committed to 6.x-1.x

Miszel commented 27 May 2012 at 22:41

Status:

Needs review

» Closed (fixed)

fixed in 6.x-.1.4