Reviewed & tested by the community
Project:
Omega
Version:
7.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
22 May 2012 at 18:34 UTC
Updated:
13 May 2016 at 16:33 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
star-szrThis is fixed in 7.x-4.x, so this is probably a won't fix for 7.x-3.x. Maintainers, what do you think?
Comment #2
simon georges commented4.x is still not the recommended version, so I suppose this should be fixed for users that are using the 3.x version (like production websites).
Are there issues when upgrading from 3.x to 4.x version?
Anyway, as there is a patch, changing status to needs review.
Comment #4
gabyyy commentedomega-html5shiv-local.patch queued for re-testing.
Comment #4.0
gabyyy commentedUpdated issue summary.
Comment #5
mforbes commentedThe patch uses
path_to_theme()which is problematic. I've seen folks report certain issues wherepath_to_theme()returns the base theme when they expected it to return the active theme, but I'm actually experiencing the opposite problem: I subthemed Omega, andpath_to_theme()in the context of html.tpl.php is the path to my subtheme. I do not include js/html5shiv.js in my subtheme, nor should I need to, so the resulting path is a 404 Not Found. The subtheming guide does not suggest unnecessarily duplicating assets from the base theme.This bit of documentation clarifies why, in this particular context of html.tpl.php,
path_to_theme()is returning my subtheme rather than Omega or Alpha: "When called outside the scope of a theming call, it will always point to the active theme." (https://api.drupal.org/api/drupal/includes%21theme.inc/function/path_to_...)What do you think about swapping out
path_to_theme()fordrupal_get_path('theme', 'omega')? The path to html5shiv.js is always composed from the path to Omega, despite Omega both having a base theme and being a base theme for something else.Comment #6
star-szrYup, +1 that makes sense to hardcode that way @mforbes. Attaching a new patch and interdiff - I also grabbed the latest html5shiv.js via the Google code URL.
Comment #7
alexiswatson commentedLooks solid. One more for RTBC?
Comment #8
alan-ps commented#1 tested and works well!