Currently tokens can be used in custom variable values, but it would also be useful to be able to use tokens in the names of the custom variables. I'm attaching a patch for review that will enable this feature.

CommentFileSizeAuthor
#24 1595176_Tests+may+depend+on+token+module.patch1.04 KBhass
#23 1595176_Allow_tokens_in_custom_variable_names7-D6.patch11.79 KBhass
#21 1595176_Allow_tokens_in_custom_variable_names6-D6.patch12 KBhass
#20 1595176_Allow_tokens_in_custom_variable_names5-D6.patch10.66 KBhass
#18 1595176_Allow_tokens_in_custom_variable_names5.patch10.4 KBhass
#17 1595176_Allow_tokens_in_custom_variable_names4.patch10.18 KBhass
#15 1595176_Allow_tokens_in_custom_variable_names4.patch10.21 KBhass
#13 1595176_Allow_tokens_in_custom_variable_names3.patch10.14 KBhass
#11 1595176_Allow tokens in custom variable names3.patch10.14 KBhass
#9 1595176_Allow tokens in custom variable names2.patch9.33 KBhass
#4 google_analytics-7.x-1.x-custom_variable_name_tokens-1595176-4.patch5.29 KBjlapp
#2 google_analytics-custom_variable_name_tokens-1595176-2.patch4.93 KBjlapp
google_analytics-custom_variable_name_tokens.patch5.27 KBjlapp

Comments

Status: Needs review » Needs work

The last submitted patch, google_analytics-custom_variable_name_tokens.patch, failed testing.

jlapp’s picture

jlapp commented
Status: Needs work » Needs review
StatusFileSize
new google_analytics-custom_variable_name_tokens-1595176-2.patch4.93 KB

Updating patch with correct file paths.

hass’s picture

hass commented
Version: 6.x-3.x-dev » 7.x-1.x-dev
Status: Needs review » Needs work

Patch does not contain tests. What tokens are you using for the name? D7 need to be done first, too.

jlapp’s picture

jlapp commented
Status: Needs work » Needs review
StatusFileSize
new google_analytics-7.x-1.x-custom_variable_name_tokens-1595176-4.patch5.29 KB

Adding a patch against 7.x-1.x-dev which also contains a test case. If the D7 patch is accepted, I will update my previous D6 patch to include tests as well.

Hass, the same tokens can be used in the name field as the value field. I used the existing validation function so that personally identifying information cannot be added in the name field either.

hass’s picture

hass commented

Since #1783870: Update 64 byte variable name limit to 128 per API changes we have a lot more chars now and can get this in. Nevertheless shouldn't we cut off the name somewhere? I still have no good idea what tokens you'd like to use in the name field. Can you share some examples, please?

hass’s picture

hass commented

#4: google_analytics-7.x-1.x-custom_variable_name_tokens-1595176-4.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, google_analytics-7.x-1.x-custom_variable_name_tokens-1595176-4.patch, failed testing.

hass’s picture

hass commented

These tests are not testing Custom Variables and setup requires token or Tokens are also not tested.

hass’s picture

hass commented
Status: Needs work » Needs review
StatusFileSize
new 1595176_Allow tokens in custom variable names2.patch9.33 KB

Patch attached.

Status: Needs review » Needs work

The last submitted patch, 1595176_Allow tokens in custom variable names2.patch, failed testing.

hass’s picture

hass commented
Status: Needs work » Needs review
StatusFileSize
new 1595176_Allow tokens in custom variable names3.patch10.14 KB

Fixed a bug with form error message.

Status: Needs review » Needs work

The last submitted patch, 1595176_Allow tokens in custom variable names3.patch, failed testing.

hass’s picture

hass commented
Status: Needs work » Needs review
StatusFileSize
new 1595176_Allow_tokens_in_custom_variable_names3.patch10.14 KB

Filename without spaces

Status: Needs review » Needs work

The last submitted patch, 1595176_Allow_tokens_in_custom_variable_names3.patch, failed testing.

hass’s picture

hass commented
Status: Needs work » Needs review
StatusFileSize
new 1595176_Allow_tokens_in_custom_variable_names4.patch10.21 KB

Token?

Status: Needs review » Needs work

The last submitted patch, 1595176_Allow_tokens_in_custom_variable_names4.patch, failed testing.

hass’s picture

hass commented
Status: Needs work » Needs review
StatusFileSize
new 1595176_Allow_tokens_in_custom_variable_names4.patch10.18 KB

test

hass’s picture

hass commented
StatusFileSize
new 1595176_Allow_tokens_in_custom_variable_names5.patch10.4 KB

Commited this patch.

hass’s picture

hass commented
Version: 7.x-1.x-dev » 6.x-3.x-dev
Status: Needs review » Patch (to be ported)
hass’s picture

hass commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new 1595176_Allow_tokens_in_custom_variable_names5-D6.patch10.66 KB

D6 patch with all tests.

hass’s picture

hass commented
StatusFileSize
new 1595176_Allow_tokens_in_custom_variable_names6-D6.patch12 KB

Missed one form validation.

Status: Needs review » Needs work

The last submitted patch, 1595176_Allow_tokens_in_custom_variable_names6-D6.patch, failed testing.

hass’s picture

hass commented
Status: Needs work » Needs review
StatusFileSize
new 1595176_Allow_tokens_in_custom_variable_names7-D6.patch11.79 KB

Let's try this from #1777980: Tests fail if optional deploy module is not present.

hass’s picture

hass commented
Version: 6.x-3.x-dev » 7.x-1.x-dev
StatusFileSize
new 1595176_Tests+may+depend+on+token+module.patch1.04 KB

D7 Test fix

hass’s picture

hass commented
Status: Needs review » Fixed

Committed all patches to D6 and D7.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.