I will be updating this task with my contributions to GSoC '12.

CommentFileSizeAuthor
#8 email_test-1595272-8.patch4.15 KBcolette
#6 email_test-1595272-6.patch4.78 KBcolette
#4 email_test-1595272-4.patch4.19 KBcolette
#3 email_microdata_extension-1595272-3.patch3.28 KBcolette
#2 email_preliminary-1595272-2.patch3.1 KBcolette
#1 email_preliminary-1595272-1.patch4.13 KBcolette

Comments

colette’s picture

colette commented
StatusFileSize
new email_preliminary-1595272-1.patch4.13 KB

Preliminary commit for the email module.

colette’s picture

colette commented
StatusFileSize
new email_preliminary-1595272-2.patch3.1 KB

Retrying the preliminary commit, now with the updated folder structure.

colette’s picture

colette commented
StatusFileSize
new email_microdata_extension-1595272-3.patch3.28 KB

Preliminary patch for email module.

colette’s picture

colette commented
StatusFileSize
new email_test-1595272-4.patch4.19 KB

Working test for the email module.

Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Needs work 
+++ b/microdata.infoundefined
@@ -6,3 +6,5 @@ dependencies[] = ctools
+; integration test for contrib modules

The first letter should be capitalized and should use a period at the end. Might as well say tests, too, since we'll be adding more.

Also, there are some whitespace problems on blank lines. You can check it out with Dreditor if you have it installed.

Other than that, I think it's good to go. I'll give it another test and final look once you have those changes made.

colette’s picture

colette commented
StatusFileSize
new email_test-1595272-6.patch4.78 KB

Here's the cleaned up version of the patch.

Anonymous’s picture

Anonymous (not verified) commented

Hmm, I think something happened to the logic here. If you look at the verbose message, there is only one field shown on the page. The test also passes when the patch to Email module isn't yet applied.

colette’s picture

colette commented
StatusFileSize
new email_test-1595272-8.patch4.15 KB

I fixed the error, and cleaned up the comments.

Anonymous’s picture

Anonymous (not verified) commented
Title: Tests for modules extended with microdata » Test microdata integration for email module

Changing title.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs work » Fixed

Fixed with commit http://drupalcode.org/project/microdata.git/commit/b5246a2

w00ts!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.