Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
23 May 2012 at 00:42 UTC
Updated:
15 Dec 2012 at 11:37 UTC
The Webclient API is seperated into three major components:
All of the above components were translated to seperate module so that developers can create a dependency with the functionality they need.
It provides no out of the box functionality other then providing an API that other modules can use.
Difference with other similar modules:
Visit project page
git clone --recursive --branch 7.x-1.x http://git.drupal.org/sandbox/daeron/1490922.git webclient
Drupal 7 module.
Comments
Comment #1
xenyo commentedHi.
while waiting for an in-depth review of your module you can start out fixing some coding style issues detected by automated tools:
http://ventral.org/pareview/httpgitdrupalorgsandboxdaeron1490922git.
You can also get a review bonus and we will come back to your application sooner.
Also, maybe expand a bit on how your project is different from similar webclient contrib modules available
Comment #2
freblasty commentedThose issues detected by ventral are intentional. Module developers that want to extend the Webclient base classes should use the corresponding functions instead to ensure that they do not break any webclient logic.
Comment #3
stuchl4n3k commentedHi freblasty, please, make sure that your $reqeust->result in webclient_extension.module @189 is not wrapped in t() intentionally. It's really nice and clean code.
Comment #4
freblasty commentedThanks for the review.
The t() function was left out intentionally because the message being assigned to $request->result should be replaced by the original request headers (which is on my todo-list).
Comment #5
rbosscher commentedIt could be that I'am missing something, but as far as I can see I didn't find the error messages for example "InvalidArgumentException" in webclient.base.inc back in the watchdog.
Comment #6
freblasty commentedCould you explain to me the steps you took to simulate such a watchdog entry?
Comment #7
freblasty commentedChanged priority to major according to the review process guideline.
Comment #8
klausiThis looks like a duplicate of http_client: http://drupal.org/project/http_client . We prefer collaboration over competition so please open an issue on the existing project to join forces. I think it is a good idea to get in touch with the maintainer(s) and discuss your requirements. If that fails for whatever reason please get back to us and set this back to "needs review".
Comment #9
klausiComment #10
klausiClosing due to lack of activity. Feel free to reopen if you are still working on this application.
Comment #10.0
klausiUpdated webclient description as requested by xenyo.