would only require the implementation of hook_ds_fields_info()... as far as I can see

CommentFileSizeAuthor
#13 addtoany_ds_expert_template.png77.63 KBRAWDESK
#5 addtoany-ds_integration-1596236-5.patch629 bytesyannickoo
#4 addtoany-implement_hook_ds_fields_info-1596236-6057876.patch2.33 KBAnonymous (not verified)
#3 addtoany-implement_hook_ds_fields_info-1596236-6057876.patch0 bytesAnonymous (not verified)
#1 addtoany-implement_hook_ds_fields_info-1596236-1.patch498 bytesloominade

Comments

loominade’s picture

loominade commented
Status: Active » Needs review
StatusFileSize
new addtoany-implement_hook_ds_fields_info-1596236-1.patch498 bytes
Anonymous’s picture

Anonymous (not verified) commented
Assigned: Unassigned »
Category: feature » bug

There's a bug when you use the ds-field to render the share-button. The $node-object used by the _addtoany_create_button() function has another structure then the object from the ds-field. You have to add a function that only provides a real $node-object.

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new addtoany-implement_hook_ds_fields_info-1596236-6057876.patch0 bytes

Here is my patch

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new addtoany-implement_hook_ds_fields_info-1596236-6057876.patch2.33 KB

sorry for the emtpy file

yannickoo’s picture

yannickoo
Location Berlin
commented
StatusFileSize
new addtoany-ds_integration-1596236-5.patch629 bytes

I removed the unnecessary changes in your patch.

torsti’s picture

torsti commented

Works for me - Thanks!

llillf’s picture

llillf commented

Hi Torsti,

It seems not work for me. Could let me know which patch above you tried and the version of your Display Suite and Addtoany?

Thanks a lot!

rcodina’s picture

rcodina
Primary language Catalan
Location Barcelona
commented
Issue summary: View changes

Patch on #5 works for me.

Display Suite 7.x-2.6
AddToAny 7.x-4.5

Could anyone test this and if it's ok mark this issue as Reviewed? Thank you!

mandreato’s picture

mandreato commented
Status: Needs review » Reviewed & tested by the community

Patch #5 works for me too.
Display Suite 7.x-2.6
Share Buttons by AddToAny 7.x-4.5

micropat’s picture

micropat commented
Category: Bug report » Feature request
Status: Reviewed & tested by the community » Fixed

Implemented in 7.x-4.6. Thanks for the patches!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

rcodina’s picture

rcodina
Primary language Catalan
Location Barcelona
commented

Please, checkout new related issue: https://www.drupal.org/node/2418423

RAWDESK’s picture

RAWDESK commented
StatusFileSize
new addtoany_ds_expert_template.png77.63 KB

I just noticed this ds integration is far from completed.
Tried to use the Expert template as illustrated in attached screenshot addtoany_ds_expert_template.png , but none of the settings are applied when rendering "the button".

Service buttons html code is set as follows at admin/config/services/addtoany : 

<h2>Share with your movie friends</h2>
<div class="a2a_kit a2a_kit_size_32 a2a_default_style" data-a2a-icon-color="unset">
  <a class="a2a_button_facebook"></a>
  <a class="a2a_button_facebook_messenger"></a>
  <a class="a2a_button_whatsapp"></a>
</div>

Notice the h2 header which is untranslatable with i18n, something ds supports out of the box.

Everything remains wrapped inside the following span : 

<span class="a2a_kit a2a_kit_size_32 a2a_target addtoany_list" id="" style="line-height: 32px;">
...
</span>

which to my honest opinion is not the appropriate html tag for wrapping.

I guess the included js logic is preventing ds to do its work properly.