The --include-vcs option is not handled properly since #1096364: rsync should allow multiple --exclude options to be specified

In drush 5 an unset statement was added which should be in an else branch.

This way the include-vcs option gets unset in cases where it does not exist...

CommentFileSizeAuthor
drush-include_vcs_option_gets_passed_directly_to_rsync.patch433 byteshelmo

Comments

moshe weitzman’s picture

moshe weitzman commented

Do we need same fix at #1547546: rsync being passed --php argument (unknown argument for rsrync)? Do we need to unset all drush global options or something?

greg.1.anderson’s picture

greg.1.anderson commented

No; the patch here looks correct, whereas I cannot reproduce #1547546: rsync being passed --php argument (unknown argument for rsrync).

helmo’s picture

helmo commented

It's definitely related to #1547546: rsync being passed --php argument (unknown argument for rsrync), but the patch here is a separate bug.

I'll comment there with some findings.

moshe weitzman’s picture

moshe weitzman commented
Status: Needs review » Fixed

Committed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.