After checking out several times I noticed the customer_profile gets created again even though one was selected from the addressbook, so to solve the shipping information I just made sure the 'copy_billing' value was unset because it was failing this check http://drupalcode.org/project/commerce.git/blob/c36b184701ac0fe6a750d854....

Additionally, to prevent shipping profile getting dups, I crosschecked the address with those stored in the addressbook being the same as the shipping being copied and if so, then use the profile_id and revision_id stored in db.

CommentFileSizeAuthor
#9 prevent-customer-profile-duplication-on-address-1597578-9.patch3.37 KBnadavoid
#8 prevent-customer-profile-duplication-on-address-1597578-8.patch3.1 KBnadavoid
#6 prevent-customer-profile-duplication-on-address-1597578-6.patch2.9 KBartkon
#5 prevent-customer-profile-duplication-on-address-1597578-5.patch2.9 KBartkon
#3 prevent-customer-profile-duplication-on-address-1597578-3.patch2.89 KBartkon
#2 prevent-customer-profile-duplication-on-address-1597578-2.patch2.88 KBartkon
#1 prevent-customer-profile-duplication-on-address-1597578-1.patch2.93 KBartkon

Comments

artkon’s picture

artkon commented
StatusFileSize
new prevent-customer-profile-duplication-on-address-1597578-1.patch2.93 KB
artkon’s picture

artkon commented
StatusFileSize
new prevent-customer-profile-duplication-on-address-1597578-2.patch2.88 KB

Sorry, I committed file mode changes, here is a good one,

artkon’s picture

artkon commented
StatusFileSize
new prevent-customer-profile-duplication-on-address-1597578-3.patch2.89 KB

Here is a final one, with some comment changes.

googletorp’s picture

googletorp commented
Status: Active » Postponed

Good work on the patch, however, the copy billing address functionality is on it's way out of commerce shipping and on it's way into commerce core. So for now will postpone and probably won't do anything if things go as planned.

See #1410022: Improve copy address functionality - create a more generic solution

artkon’s picture

artkon commented
StatusFileSize
new prevent-customer-profile-duplication-on-address-1597578-5.patch2.9 KB

Updated patch: To prevent a PHP notice I inserted an if (!empty($profile_id)) on line 1050 of commerce_shipping.module

Fixed Notice: Undefined variable: profile_id in commerce_shipping_commerce_customer_profile_presave() (line 1050 of /mnt/apci/pdupstore/www/profiles/apci_store/modules/contrib/commerce_shipping/commerce_shipping.module).

artkon’s picture

artkon commented
StatusFileSize
new prevent-customer-profile-duplication-on-address-1597578-6.patch2.9 KB

Previous patch was not applying cleanly, attached is a working patch.

rszrama’s picture

rszrama commented
Status: Postponed » Closed (fixed)

Closing this now that the core patch has been committed.

nadavoid’s picture

nadavoid commented
StatusFileSize
new prevent-customer-profile-duplication-on-address-1597578-8.patch3.1 KB

Updated patch #6 adds condition so that it applies only during checkout. Previously, it was taking effect when editing an existing shipping address.

Also added a @todo in our local site to upgrade to the latest version of commerce, so we won't need this patch at all.

nadavoid’s picture

nadavoid commented
StatusFileSize
new prevent-customer-profile-duplication-on-address-1597578-9.patch3.37 KB

Updated patch to allow a duplicate to be made if using an address that was used on a previous order. This is done by checking $profile->revision_id.