I will update the email module with microdata.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | email_microdata_extension-1597622-8.patch | 2.21 KB | colette |
| #7 | email_microdata_extension-1595272-7.patch | 2.21 KB | colette |
| #5 | email_microdata_extension-1595272-5.patch | 2.67 KB | colette |
| #3 | email_microdata_extension-1595272-3.patch | 3.3 KB | colette |
| #2 | email_microdata_extension-1595272-1.patch | 3.28 KB | colette |
Comments
Comment #1
colette commentedPreliminary patch.
Comment #2
colette commentedPreliminary patch.
Comment #3
colette commentedComment #4
Anonymous (not verified) commentedIt looks like there are a few changes in that patch that aren't related to microdata. I think you might need to git checkout again.
For the lines that are related to microdata, let's move them below the rest of the logic (right above the break) and add a comment. This comment should be broken at 80 characters, per the style guide. You will see a line at 80 characters in Komodo Edit.
Comment #5
colette commentedHere's the cleaned up version of the patch.
Comment #6
Anonymous (not verified) commentedThis comment should say "Extended microdata integration for Email module."
Right now, there is only one hook, but we may add more.
This comment should just say "Implements hook_microdata_suggestions()."
I believe "Therefore," can move up a line (at least, it looks like it when I apply the patch and view it in Komodo IDE), which would reduce this from 5 lines to 4.
This is the second instance of this comment, which I asked you to place. In looking at this, I realize it's a pretty big comment to duplicate. How about "Unset microdata. See comment above in email_contact."
Comment #7
colette commentedHere's the patch with the updated comments.
Comment #8
colette commentedI just realized the issue number was wrong, here's the new patch.
Comment #9
Anonymous (not verified) commentedAn issue has been created for this in the Email module, #1613346: Extending email field with microdata
Comment #10
Anonymous (not verified) commented