Patch to follow

CommentFileSizeAuthor
#4 recurly-D6.patch156.67 KBloze
#1 recurly-d6-1597692-1.patch9.7 KBronan

Comments

ronan’s picture

ronan commented
StatusFileSize
new recurly-d6-1597692-1.patch9.7 KB

This is a pretty straightforward D6 patch. It requires dbtng instead of backporting the DB code and it wraps the changed hook names and preserves d7 code style to make applying D7 patches easier in the future.

This patch also has #2 from #1289192: Recurly API changes break authentication and #2 from #1190686: In recurly_schema() recurly_account.status field 'length' is written as 'size' applied as they were needed to get the thing running in order to port. I can reroll if and when those issues are resolved.

Ronan

quicksketch’s picture

quicksketch
he/him
commented
Status: Needs review » Fixed

Thanks Ronan! Ryan gave me commit access to this project so I'm helping move it forward.

I've committed this patch as-is to a new 6.x-1.x branch, however I think moving forward it would be preferable to remove the dependency on DBTNG module. We've only got two DB queries in the whole module, it'd be trivial to update them. Especially considering these DB calls are exclusively within CRUD operations, I don't think we'll be needing to maintain significant differences in the code (or at least any more than we're already doing for trivial string replacements or theme() calls).

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

loze’s picture

loze commented
StatusFileSize
new recurly-D6.patch156.67 KB

Thanks,

I needed this for a D6 project, but found the D6 branch was outdated with some of the current d7 features, such as the user account pages and the api hooks.

This attached patch should bring it up to date with the D7 versions features (or at least start to)
I have only tested it using user entities and the hosted payment pages. But it seems to be working for my use case.

I have also removed the DBTNG dependency as quicksketch suggested.

This patch is against the D6 branch. I hope this helps someone.

Thanks again.

loze’s picture

loze commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
Status: Closed (fixed) » Needs review
quicksketch’s picture

quicksketch
he/him
commented
Status: Needs review » Closed (won't fix)

We're not going to support this module in Drupal 6. I talked with Drew Gorton (who works with @ronan) and it seems that they no longer need the D6 port of this module since they ported their product to D7. At this point in the release cycle, I don't think it's worth the effort of attempting to support D6.