Problem/Motivation

The fade transition isn't great, the speed in/out parameters in jquery.cycle lessen this somewhat by smoothing out the sudden 'pop-in' of images.

Proposed resolution

Patch attached. Adds (optional) speed in/out fields to the field settings and sets these parameters in jquery.cycle's options variable if they're set.

Remaining tasks

Reviews needed.

User interface changes

Two new fields 'speed in' and 'speed out' in the field settings form.

API changes

None.

CommentFileSizeAuthor
#3 field_slideshow-speed_in_out-1597762-3.patch3.94 KBtorpy
field_slideshow-speed_in_out-0.patch4.04 KBtorpy

Comments

torpy’s picture

torpy commented
Status: Active » Needs review
idflood’s picture

idflood commented

Thanks for this patch, it looks really good. I've still not tested it but I have a little question.

Is there any reason why you use the 2 !empty(...) at the end of the patch? Looking at the code it seems that the default value is '' so it should work by simply assigning the variable, or did I missed something?

'#speed_in'             => $settings['slideshow_speed_in'],
// instead of
'#speed_in'             => (!empty($settings['slideshow_speed_in'])) ? $settings['slideshow_speed_in'] : '',
torpy’s picture

torpy commented
StatusFileSize
new field_slideshow-speed_in_out-1597762-3.patch3.94 KB

Ha, I think it's a holdover from before I'd set the default value and was getting "index doesn't exist" errors. New, cleaner patch attached :)

lamp5’s picture

lamp5
Primary language Polish
Location Rzeszow
commented
Issue summary: View changes
Status: Needs review » Closed (works as designed)