Key:
C = clarification
F = fix to avoid common problems
S = simple change
Changes:
- C - Rename "Miscellaneous" to "Project Maintenance"
- F - Remove "Feature module support"
- S - Add "Discussion Group Maintenance"
- S - Add "Other"
- C - Rename Provided Rules integration to "Provided module integrations"
- C - Rename "Rules Engine" to "Rules Core"
- C - Rename "Forms Support" to "Forms Support (D6)"
Justifications and Comments
- Misc is a problem waiting to happen right off the bat. Any clarity issues in the component list leads to this as the default choice for some users. On the other hand, it's kinda lucky that when looking at the list of issues, this theme popped out to me.
- There are more than 2200 issues and less than 30 are in this. Many of these are actually misfiled but many more other issues were originally misfiled here, so the obvious answer is to fold it into "Provided Rules integration"
- We don't have a way to administer gdo/rules yet, and I've proposed a number of changes that currently only fit under Misc. It makes sense to me.
- I'm not sure this is even necessary. With these changes, it might be possible to wait and see if new issues seem misfiled or if we nailed it and the total Rules user experience of "Hey! [this] needs to be changed, and its part of [that]."
- It's just an odd wording for what it is. First, it being singular is off, imo, and second, it makes sense, but it's still hard to understand for a reason that's hard to describe. Also, I'm not sure that 'provided' actually outweighs the cost/benefit of its intended benefit. I think #1597880: Update Rules Issue Queue Guidelines will be a good way to clarify the difference between Rules' provided integrations versus modules that provide integrations. Personally, I don't see this is a major pain point in the issue queue. It's not often that people file issues in this queue that belong in another, and even when they do, they get other eyes first.
- This one might be subjective, however the engine is, AFAIK, only one layer of the code (the deepest), and things like entity api integration and data calculation actions aren't part of the engine, but currently fit best in that component.
- I don't actually like this change, but the current state of Rules Forms Support is kinda weird. Theoretically, there should only be the porting issue under Forms Support in D7, but then why even keep the component? Why not find some way to rework the location of the D6 issues and get rid of it completely? Like, why not move D6 forms support entirely into the other project, and then move all the issues over there two. The answer to that is obvious. But then again, why not merge the other project back into core and give that maintainer permission to commit to that module only. I know that a new major version is underway, so this might be a good time to consider that approach.
Better order:
- Rules Core
- User Interface
- Provided Module Integrations
- Documentation
- Project Maintenence
- Discussion Group Maintenence
- Scheduler
- Forms Support
- Other
There might still be some low hanging fruit here aside from my observations. I propose we request additional feedback and figure out a deployment plan in the meantime, then make the change and move on to more interesting things.
Comments
Comment #1
klausiLooks all fine to me. I granted you access to the project page and the issue queue settings, so just go right ahead.
Comment #2
mitchell commentedUpdated component.
Comment #3
mitchell commentedUpdated component.
Comment #4
mitchell commentedI apologize to those who received a lot of emails, though it should easier to submit new issues and find old ones that should be worked into the handbook.
Comment #5
fagoGood improvements - thanks!
I dislike one thing though, the "Discussion Group Maintenance" point. I don't think there will be enough issues in that category to warrant a separate point possibly confusing users + we have project maintenance what fits it very well I'd say?
Thus, I've removed it for now. If you feel like it's still necessary, please reopen and discuss :)
Comment #5.0
fagoa
Comment #7
mitchell commentedAs you guys probably noticed, this wasn't a 100% clean change. #140989: Renaming components is unsafe so I had to ask the webmasters, #1666886: Please help with renaming components of existing issues. Thankfully, a Rules power user / maintainer, OnkelTem, picked this up and killes was very patient during testing.
Now, every single issue is categorized; there is not a single orphan from any of the changes over the years, and critically, issue comments will not unexpectedly change the component because a pre-existing component was deleted or renamed (see #1 there).
---
I made a few additional changes (already implemented, but they're all pretty easy to undo):
* Capitalized 'User interface' to match the overall appearance
* Removed 'Other' for the same reason as 'Miscellaneous'
* Renamed 'Provided module integrations' and '..integration' to 'Module Integrations' [1]
[1]: This helps to fit overall appearance; and, it helps to account for the scenarios where users aren't sure if a feature is provided internally or externally, where an issue is patiently spun off into a separate module, and where module maintainers have support requests regarding their own projects.
I also changed the order:
From:
To:
Reasons:
* I think users will be too quick to pick UI, if it's 2nd, instead of analyzing the list and investigating the appropriate component, because a lot of things can be considered UI issues.
* Module Integrations is the second most commonly used component.
* Documentation's placement is good, not too high, not too low. It even has a lot more issues than I expected.
* Overall, this order seems to best reflect the current priorities and/or % of use.
* The placement of Scheduler and Forms Support are good, but their names / status could use work, see #1780484: Rename Scheduler to Queue Scheduler & #1780526: Support Entity Validation in D8.
* Project Maintenance is used least, so it should be at the bottom.
Last note: This is the first issue with the 'MX' tag. It means 'Maintainer Experience'. I added this because, IMHO, these changes make maintaining the issue queue much easier and the users who take a more active role of maintaining Rules will appreciate these changes the most. @fago & @klausi & @all-self-prescribed-maintainers: Please don't hesitate to reopen this to ask for clarifications, reversions, or other suggestible improvements.
Comment #7.0
mitchell commentedremoved into text