Download & Extend

Move closure filling to the actual end

Project:Drupal core
Version:6.x-dev
Component:theme system
Category:bug report
Priority:normal
Assigned:Gábor Hojtsy
Status:closed (fixed)

Issue Summary

Themes output the hook_footer() output on the bottom of the page, and this is the latest time we can do something to output on the page. Unfortunately theme.inc fills the closure variable (with output from hook_footer()) before doing lots of parts of the page. The theme variables filled were ordered in alphabetical order, which put the closure filling to a bad place.

For hook_footer() to be able to provide a list of db queries used on the page (devel module), or provide a list of locale strings used on the page (l10n_client module), the closure should be filled in last. The attached patch does just this, and because I moved the closure out of the alphabetical order, I added a small comment.

AttachmentSizeStatusTest resultOperations
move.closures.to_.the_.end_.patch1.26 KBIgnored: Check issue status.NoneNone

Comments

#1

Status:needs review» reviewed & tested by the community

trivial, so RTBC.

#2

Status:reviewed & tested by the community» fixed

OK, comitted.

#3

Status:fixed» closed (fixed)
nobody click here