Based on discussions in #1593058: Remove system.info's files[] entry, we are to move the tests in ajax.test over to PSR-0.
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | 1598548-ajax-tests-psr-0-13.patch | 49.19 KB | Niklas Fiekas |
| #13 | 1598548-diff-of-the-patches.txt | 652 bytes | Niklas Fiekas |
| #11 | 1598548-find-copies-harder-11.txt | 82.33 KB | Niklas Fiekas |
| #9 | 1598548.patch | 49.21 KB | robloach |
| #7 | 1598548-7.patch | 48.81 KB | robloach |
Comments
Comment #1
robloachComment #2
aspilicious commentedNeeds an @file above this line
Should be "AjaxTestBase"
@file missing
AjaxBaseTest
Same for the other classes
5 days to next Drupal core point release.
Comment #3
robloachThanks!
Comment #4
robloachWrong patch.
Comment #5
robloachNeeded a rebase.
Comment #6
aspilicious commentedMultiFormTest
Srry missed that :)
5 days to next Drupal core point release.
Comment #7
robloachGood catch.
Comment #8
aspilicious commentedTest file needs to be deleted from the .info file
Comment #9
robloachComment #10
aspilicious commentedGood!
Comment #11
Niklas Fiekas commentedAs sun suggested, here's a diff with lower thresholds for rename detection, showing that almost everything is coming from ajax.test 1:1.
Comment #12
jhodgdonI am not able to apply the patch in #9 with git apply, and based on past experience with these PSR-0 patches, the patch command doesn't get all the stuff right with adding/renaming/removing files. So I guess this needs a reroll.
Comment #13
Niklas Fiekas commentedRerolled.
Comment #14
aspilicious commentedwtf, that interdiff is prety strange but the patch it self looks prety good.
25 days to next Drupal core point release.
Comment #15
dries commentedCommitted to 8.x. Thanks.