Comments

robloach’s picture

Status: Active » Needs review
StatusFileSize
new48.71 KB
aspilicious’s picture

Status: Needs review » Needs work
+++ b/core/modules/system/lib/Drupal/system/Tests/Ajax/AjaxTest.phpundefined
@@ -0,0 +1,66 @@
+ * Definition of Drupal\system\Tests\Ajax\AjaxTest.

Needs an @file above this line

+++ b/core/modules/system/lib/Drupal/system/Tests/Ajax/AjaxTest.phpundefined
@@ -0,0 +1,66 @@
+class AjaxTest extends WebTestBase {

Should be "AjaxTestBase"

+++ b/core/modules/system/lib/Drupal/system/Tests/Ajax/CommandsTest.phpundefined
@@ -0,0 +1,160 @@
+ * Definition of Drupal\system\Tests\Ajax\CommandsTest.

@file missing

+++ b/core/modules/system/lib/Drupal/system/Tests/Ajax/CommandsTest.phpundefined
@@ -0,0 +1,160 @@
+class CommandsTest extends AjaxTest {

AjaxBaseTest

Same for the other classes

5 days to next Drupal core point release.

robloach’s picture

Status: Needs work » Needs review
StatusFileSize
new370.49 KB

Thanks!

robloach’s picture

Status: Needs review » Needs work

Wrong patch.

robloach’s picture

Status: Needs work » Needs review
StatusFileSize
new48.81 KB

Needed a rebase.

aspilicious’s picture

Status: Needs review » Needs work
+++ b/core/modules/system/lib/Drupal/system/Tests/Ajax/MultiFormTest.phpundefined
@@ -0,0 +1,85 @@
+ * Definition of Drupal\system\Tests\Ajax\MultiFormTestCase.

MultiFormTest

Srry missed that :)

5 days to next Drupal core point release.

robloach’s picture

Status: Needs work » Needs review
StatusFileSize
new48.81 KB

Good catch.

aspilicious’s picture

Status: Needs review » Needs work

Test file needs to be deleted from the .info file

robloach’s picture

Status: Needs work » Needs review
StatusFileSize
new49.21 KB
aspilicious’s picture

Status: Needs review » Reviewed & tested by the community

Good!

Niklas Fiekas’s picture

StatusFileSize
new82.33 KB

As sun suggested, here's a diff with lower thresholds for rename detection, showing that almost everything is coming from ajax.test 1:1.

jhodgdon’s picture

Status: Reviewed & tested by the community » Needs work

I am not able to apply the patch in #9 with git apply, and based on past experience with these PSR-0 patches, the patch command doesn't get all the stuff right with adding/renaming/removing files. So I guess this needs a reroll.

Niklas Fiekas’s picture

Status: Needs work » Needs review
StatusFileSize
new652 bytes
new49.19 KB

Rerolled.

aspilicious’s picture

Status: Needs review » Reviewed & tested by the community
+++ 1598548_2.patch	2012-05-26 17:04:58.000000000 +0200
@@ -617,13 +617,13 @@
  ; Tests in tests directory.
+ files[] = tests/actions.test
 -files[] = tests/ajax.test
  files[] = tests/batch.test

wtf, that interdiff is prety strange but the patch it self looks prety good.

25 days to next Drupal core point release.

dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks.

Automatically closed -- issue fixed for 2 weeks with no activity.