Based on discussions in #1593058: Remove system.info's files[] entry, we are to move the tests in cache.test over to PSR-0.
| Comment | File | Size | Author |
|---|---|---|---|
| #24 | cache-tests-psr0-followup.patch | 24.35 KB | aspilicious |
| #19 | 1598558-cache-tests-psr-0-19.patch | 44.88 KB | Niklas Fiekas |
| #16 | 1598558.patch | 31.72 KB | robloach |
| #11 | 1598558-cache-tests-psr-0-10.patch | 50.7 KB | Niklas Fiekas |
| #11 | 1598558-cache-tests-psr-0-10-interdiff.txt | 3.87 KB | Niklas Fiekas |
Comments
Comment #1
Niklas Fiekas commentedDoing this next.
Comment #2
Niklas Fiekas commentedClasses converted.
I have also attached the concatenated output of
git blame -Con the new files, showing that the code is coming mostly 1:1 from the old test file. Best viewed without Dreditor or automatic linewrapping, or zoomed out, to get an overview.Comment #4
Niklas Fiekas commentedHad to prefix one instance of \stdClass.
Comment #5
Niklas Fiekas commentedHad to prefix on instance of stdClass with \.
Huh ... wierd. When I tried to save the comment it said "You have no access to any project." Then, visiting this issue, no comment appeared. So posting the same thing again. And now both are there ;)
Comment #6
aspilicious commentedCan we put use stdClass on top of the file (like we have done in other place in core) for the moment. Untill we decide to undo that ;)
Comment #7
Niklas Fiekas commentedOh, yes, we can. Actually I wanted to do this right after opening the discussion issue, to not hold this up. Thanks for the reminder. Also solved a merge conflict in the .info file.
(And it looks like there were reasons to have use-statements rather than inline slashes, although I don't like that.)
Comment #8
aspilicious commentedgood!
Comment #9
Niklas Fiekas commentedI believe this doesn't apply anymore. #7: 1598558-cache-tests-psr-0-7.patch queued for re-testing.
Comment #11
Niklas Fiekas commentedUsing the chance to also rename TestBase to the less generic CacheTestBase, even though the namespace is already Cache, as discussed in IRC.
Comment #12
aspilicious commentedGreat, we don't need to reroll if the .info file conflicts. Catch is going to ignore that and leave that cleanup for the end.
Comment #13
jhodgdonIn that case, I'll leave the rest of these for catch to commit, since I don't know anything about this plan.
Comment #14
robloach#11: 1598558-cache-tests-psr-0-10.patch queued for re-testing.
Comment #16
robloachRe-roll without the system.info change, with rename detection.
Comment #17
aspilicious commentedback to rtbc
Comment #18
aspilicious commentedNeeds a reroll :( http://drupalcode.org/project/drupal.git/commitdiff/5b8960df6d2cf33abba4...
Comment #19
Niklas Fiekas commentedMerged.
Comment #20
robloachtestMinimumCacheLifetime, setupLifetime, and the section of CacheInstallTestCase arn't presented in the patch anymore. Looks good!
Comment #21
webchickCommitted and pushed to 8.x. Thanks!
Comment #22
aspilicious commentedYou accidently forgot to add the new files.
Comment #23
aspilicious commentedComment #24
aspilicious commentedShould do it, lets wait for the bot
Comment #25
Niklas Fiekas commentedRTBC seconded.
Comment #26
webchickNow with git apply --index. :P
Committed and pushed to 8.x. Thanks!
Comment #27
Niklas Fiekas commentedYay! Thanks.
Comment #28
Niklas Fiekas commented