Based on discussions in #1593058: Remove system.info's files[] entry, we are to move the tests in lock.test over to PSR-0.

CommentFileSizeAuthor
#7 1598586.patch1.19 KBrobloach
#4 1598586.patch1.15 KBrobloach
#1 15985386.patch748 bytesrobloach

Comments

robloach’s picture

robloach
he/him
commented
Status: Active » Needs review
StatusFileSize
new 15985386.patch748 bytes

lock.test only have one test, so I'm not sure it needs its own Lock namespace. What do you think?

Status: Needs review » Needs work

The last submitted patch, 15985386.patch, failed testing.

Niklas Fiekas’s picture

Niklas Fiekas commented

Mhh ... not sure about that and why the tests are failing. Either way the old file[] entry has to be removed from the .info file.

robloach’s picture

robloach
he/him
commented
Status: Needs work » Needs review
StatusFileSize
new 1598586.patch1.15 KB

Interesting indeed.

Niklas Fiekas’s picture

Niklas Fiekas commented
Status: Needs review » Reviewed & tested by the community

This one looks good to me. Also we don't need lower thresholds for rename detection.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

This needs a quick reroll -- system.info has changed and I can't use git apply to apply the patch in #4. (The patch utility doesn't work well with renames in my recent experience.)

robloach’s picture

robloach
he/him
commented
Status: Needs work » Needs review
StatusFileSize
new 1598586.patch1.19 KB
aspilicious’s picture

aspilicious commented
Status: Needs review » Reviewed & tested by the community

Good

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Thanks! Committed to 8.x.

Automatically closed -- issue fixed for 2 weeks with no activity.