Comments

cosmicdreams’s picture

Status: Active » Needs review
StatusFileSize
new24.93 KB

First Try

cosmicdreams’s picture

rerolled with name change for file and function to PagerTest as per aspillicious's request. Also using git format-path here.

cosmicdreams’s picture

StatusFileSize
new1.88 KB

second try to do the additional cleanup AND create one file with the format-patch.

Status: Needs review » Needs work
Issue tags: -PSR-0

The last submitted patch, 0001-Pager-PSR-0.patch, failed testing.

cosmicdreams’s picture

Status: Needs work » Needs review

#3: 0001-Pager-PSR-0.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +PSR-0

The last submitted patch, 0001-Pager-PSR-0.patch, failed testing.

aspilicious’s picture

add

use SimpleXMLElement;

on top of the file and everything will be green.

cosmicdreams’s picture

StatusFileSize
new1.93 KB

Wow, did my first rebase -i. That was an educational experience. Anyway here's a new patch for the system to test.

cosmicdreams’s picture

Status: Needs work » Needs review
robloach’s picture

Status: Needs review » Reviewed & tested by the community

Well done!

catch’s picture

Issue tags: -PSR-0

#8: 0001-Pager-PSR-0.patch queued for re-testing.

Status: Reviewed & tested by the community » Needs work
Issue tags: +PSR-0

The last submitted patch, 0001-Pager-PSR-0.patch, failed testing.

aspilicious’s picture

Status: Needs work » Needs review
StatusFileSize
new1.89 KB

Rerolled

robloach’s picture

Status: Needs review » Reviewed & tested by the community

If we were smart, we'd coordinate these patches without needing a reroll for system.info all the time :-) .

catch’s picture

From now on I'm going to just ignore system.info hunks if they don't apply (or if they're not there at all), and we can nuke those at the end all at once.

catch’s picture

Status: Reviewed & tested by the community » Fixed

Thanks! Committe/pushed.

Automatically closed -- issue fixed for 2 weeks with no activity.