The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.Based on discussions in #1593058: Remove system.info's files[] entry, we are to move the tests in symfony.test over to PSR-0.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | symfony-remove-system-info-cleanup.patch | 2.48 KB | aspilicious |
Comments
Comment #1
Niklas Fiekas commentedThis one is just as ironic as #1598604: Convert registry.test to PSR-0, although a bit more subtle:
A test case (that wouldn't be loaded without functioning PSR-0) tests if it can load classes with PSR-0. We can remove this together with the registry: #1541674: Remove the registry.
Comment #2
robloachActually, although it is rather strange to have this test, we should just have an issue just to track its removal. When we remove the registry, I assume we'll also remove registry.test. But, for symfony.test? We could either remove that before, or as a follow up to the removal of the registry.
Comment #3
aspilicious commentedI would like to remove this when we rome the .info files[] stuff. Else we have one files[] line left.
Comment #4
David_Rothstein commentedI don't think I agree that this test serves no purpose.
It's testing that Symfony code can be autoloaded correctly, not that simpletest code can be. Those two aren't the same thing, and it's possible that one could fail but not the other. (The fact that both currently use PSR-0 does make that less likely, but certainly not impossible; and in any case, that's an implementation detail that the test shouldn't have to concern itself with.)
However, while working on #1632364: Write tests to ensure that all classes in Drupal can actually be found by the autoloader (and after reading this issue) I did realize that with some small extensions to the patch I posted there, we could actually make it so that patch tests autoloading of all Symfony classes, rather than just a single random one like we currently do. At that point, symfony.test would become obsolete and could be removed.
Comment #5
aspilicious commentedSo let's do that in that issue. And remove symfony.test there.
Comment #6
aspilicious commentedWorking on a patch. Now that all the other stuff is converted!
Comment #7
aspilicious commentedComment #8
Tor Arne Thune commentedIf David is okay with incorporating the test in symfony.test into the other issue, this looks RTBC.
Comment #9
David_Rothstein commentedYeah, I suppose it's fine to kill it now if it's blocking other things. I'm pretty confident we can add back something more comprehensive in the other issue.
Comment #10
webchickCommitted and pushed to 8.x! Thanks. :)