! :)

CommentFileSizeAuthor
#8 1599004-8.patch904 bytesanavarre
#6 1599004-6.patch904 bytesanavarre
#4 1599004-4.patch883 bytesBrockBoland
#1 0001-Issue-1599004-by-ericduran-Added-support-github.patch751 bytesericduran

Comments

ericduran’s picture

ericduran commented
Status: Active » Needs review
StatusFileSize
new 0001-Issue-1599004-by-ericduran-Added-support-github.patch751 bytes

Here you go. No icons attached, I'll leave it to someone else to find the icons.

q0rban’s picture

q0rban commented
Status: Needs review » Needs work

Thanks, once you have icons we can add this. Also, if you have no intention of creating icons, you can always use the follow API to add your own networks.

ericduran’s picture

ericduran commented

@q0rban yea, but I figured this is a generic enough network that it would be a good addition to the module.

BrockBoland’s picture

BrockBoland commented
StatusFileSize
new 1599004-4.patch883 bytes

The Paul Robert Lloyd icon set already has a Github icon. Not sure what to do about the others; the two sizes of WPZOOM are available here, but don't include Github:
http://speckyboy.com/2011/08/24/50-social-media-bookmarking-icon-sets-20...

This patch just styles the Github icon when using the Paul Robert Lloyd icons.

anavarre’s picture

anavarre
Primary language French
Location 🇪🇺
commented

Confirmed that Paul Lloyd's Github icon works fine on a test site.

anavarre’s picture

anavarre
Primary language French
Location 🇪🇺
commented
StatusFileSize
new 1599004-6.patch904 bytes

Since the patch in #5 was posted, there were a few changes with the module's files so here's a new patch to make it up-to-date with 7.x-2.x

anavarre’s picture

anavarre
Primary language French
Location 🇪🇺
commented
Issue summary: View changes
Status: Needs work » Needs review
anavarre’s picture

anavarre
Primary language French
Location 🇪🇺
commented
Version: 7.x-1.x-dev » 7.x-2.x-dev
StatusFileSize
new 1599004-8.patch904 bytes

Seems that 7.x-2.x has slightly changed.

Patch needs icons/paulrobertlloyd32/icon-github.png to be available.

astonvictor’s picture

astonvictor commented
Status: Needs review » Closed (outdated)

I'm closing it because the issue was created a long time ago without any further steps.

if you still need it then raise a new one.
thanks