VCS (Virtual Card Services)

Hello

Ventral reports some coding standards issues for your project - http://ventral.org/pareview/httpgitdrupalorgsandboxabhishekkukku1599214git

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

Review of the master branch:

• README.txt is missing, see the guidelines for in-project documentation.
• ./uc_vcs.module: all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming
  
  

  <br>
  function uc_payment_method_vcs($op, &amp;$arg1) {<br>
  

• Remove all old CVS $Id tags, they are not needed anymore.
  
  

  <br>
  uc_vcs.module:2:// $Id$<br>
  

• PHP Parse error: syntax error, unexpected $end in ./uc_vcs.pages.inc on line 1
  
  Errors parsing ./uc_vcs.pages.inc

you should fix the PHP error ASAP really :)

Hope this helps

Pat

hey,

I don't use drupal 6 so I can't test really. I will give the code a quick once over but if you review other projects you get a review bonus (http://drupal.org/node/1410826) and some one will come look at your code quicker.

README.txt
has not to be empty

uc_vcs.module
Function parameter declaration is missing.
http://drupal.org/node/1354

uc_vcs_payment_method()
Better use theme("image", ...)
http://api.drupal.org/api/drupal/includes!theme.inc/function/theme_image/6

uc_vcs_payment_method_vcs()
$_SESSION['pay_method'] = $_POST['pay_method'];
You set session by unescaped post values.
Better use check_plain() or filter_xss()

VCS (Virtual Card Services) works with ubercart-3.x with drupal-6.x and based on uc_2checkout.

This can't be right, as Ubercart 3 works with Drupal 7, not Drupal 6. Please update your issue summary.

Also, the 2checkout module has had several bug fixes lately. You may wish to check out the development branch of Ubercart to see if those fixes are relevant to your module.