Download & Extend
Drupal Commerce » Issues

Small typo - i not î

Posted by bendiy on May 24, 2012 at 9:07pm
Project:Drupal Commerce
Version:7.x-1.x-dev
Component:Customer
Category:bug report
Priority:minor
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

I found a weird character in a comment when I was reading the code.
î

Turns out it's an:
î

Patch to follow.

Login or register to post comments

Comments

#1

Posted by bendiy on May 24, 2012 at 9:09pm

Patch attached.

AttachmentSizeStatusTest resultOperations
commerce-i_not_i-1599336-01.patch642 bytesIdlePASSED: [[SimpleTest]]: [MySQL] 3,567 pass(es).View details

#2

Posted by Damien Tournoud on May 24, 2012 at 9:12pm
Status:reviewed & tested by the community» needs review

There are two others like that: in commerce_line_item.module and commerce_product_reference.module (probably copy/paste of an original typo).

Also, if you are not seeing î properly here, it means that your editor is not configured properly.

#3

Posted by vasike on May 25, 2012 at 10:27am

i can confirm the other cases, pointed by Damien.
and here is the patch

AttachmentSizeStatusTest resultOperations
commerce-i_not_i-1599336-03.patch1.9 KBIdlePASSED: [[SimpleTest]]: [MySQL] 3,567 pass(es).View details

#4

Posted by rszrama on May 25, 2012 at 2:09pm
Status:needs review» fixed

Funny. And re: what Damien said about your IDE, make sure you're viewing files with the UTF-8 character set (though in this case it helped you find the problem to not be).

#5

Posted by bendiy on May 25, 2012 at 2:58pm

Thanks for the tip. Encoding was set to "Cp1252".

#6

Posted by System Message on June 8, 2012 at 3:01pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.