Posted by dvessel on July 17, 2007 at 4:54am
| Project: | Drupal core |
| Version: | 6.x-dev |
| Component: | theme system |
| Category: | bug report |
| Priority: | minor |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
Single theme function converted (block_admin_display). Moved to block.admin.inc.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| tplify_block_1.patch | 8.47 KB | Ignored: Check issue status. | None | None |
Comments
#1
Whoops. minor doxygen change.
#2
And again.. misnamed block-admin-display.tpl.php in doxygen.
#3
I don't think block-admin-display.tpl.php is a likely candidate to be themed, but hey ... why not.
#4
Yeah, I just got a list from Merlinofchaos so I'll focus on the more important ones from here on out. But block_admin_display had a good chunk of code moved over to block.admin.inc so there will be less to load.
#5
Committed to CVS HEAD. Thanks dvessel.
#6
Gah!! I'm sorry Dries, drupal_rebuild_theme_registry() was in there while I was debugging and forgot to pull it. Do I create a small patch just to remove it or redo the whole thing?
#7
Tiny patch removes my error.
#8
Committed to CVS HEAD. Thanks.
#9
without at least *SOME* call to rebuild the theme registry, the block administration page never appears on a fresh install. HEAD is currently borked.
#10
Darn, it must be because the move to block.admin.inc which goes missing the first time the registry gets cached. Might be better to just move it back to block.module.
Sorry, my bad.
#11
Dries: I assume you committed this originally due to having less code in the main block.module. This patch moves it back so it may not be of much value anymore but I provide it here just in case.
Lessen learned, never include theme functions that are inside conditionally included files.
#12
Dries: I assume you committed this originally due to having less code in the main block.module. This patch moves it back so it may not be of much value anymore but I provide it here just in case.
Lessen learned, never include theme functions that are inside conditionally included files.
#13
Dries: I assume you committed this originally due to having less code in the main block.module. This patch moves it back so it may not be of much value anymore but I provide it here just in case.
Lesson learned, never include theme functions that are inside conditionally included files.
#14
Committed to CVS HEAD. Thanks.
#15
#16
Reopening this due to a minor api change to help in these conditions. Code moved back to block.admin.inc and set a "file" for the registry.
#17
the patch..
#18
Committed to CVS HEAD. Thanks. (Btw, did we properly document that API change in the documentation?)
#19
Not yet, it'll be changed in both the theme, and module dev guide.
#20