Single theme function converted (block_admin_display). Moved to block.admin.inc.

CommentFileSizeAuthor
#17 mv_admin_block.patch5.75 KBdvessel
#13 tplify_block_mv_1.patch5.46 KBdvessel
#12 tplify_block_mv_0.patch5.46 KBdvessel
#11 tplify_block_mv.patch5.46 KBdvessel
#7 rm_rebuild_theme_registry.patch515 bytesdvessel
#2 tplify_block_3.patch8.46 KBdvessel
#1 tplify_block_2.patch8.46 KBdvessel
tplify_block_1.patch8.47 KBdvessel

Comments

dvessel’s picture

dvessel commented
StatusFileSize
new tplify_block_2.patch8.46 KB

Whoops. minor doxygen change.

dvessel’s picture

dvessel commented
StatusFileSize
new tplify_block_3.patch8.46 KB

And again.. misnamed block-admin-display.tpl.php in doxygen.

dries’s picture

dries commented

I don't think block-admin-display.tpl.php is a likely candidate to be themed, but hey ... why not.

dvessel’s picture

dvessel commented

Yeah, I just got a list from Merlinofchaos so I'll focus on the more important ones from here on out. But block_admin_display had a good chunk of code moved over to block.admin.inc so there will be less to load.

dries’s picture

dries commented
Status: Needs review » Fixed

Committed to CVS HEAD. Thanks dvessel.

dvessel’s picture

dvessel commented
Status: Fixed » Needs work

Gah!! I'm sorry Dries, drupal_rebuild_theme_registry() was in there while I was debugging and forgot to pull it. Do I create a small patch just to remove it or redo the whole thing?

dvessel’s picture

dvessel commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new rm_rebuild_theme_registry.patch515 bytes

Tiny patch removes my error.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

eaton’s picture

eaton commented
Category: task » bug
Priority: Normal » Critical
Status: Fixed » Active

without at least *SOME* call to rebuild the theme registry, the block administration page never appears on a fresh install. HEAD is currently borked.

dvessel’s picture

dvessel commented

Darn, it must be because the move to block.admin.inc which goes missing the first time the registry gets cached. Might be better to just move it back to block.module.

Sorry, my bad.

dvessel’s picture

dvessel commented
StatusFileSize
new tplify_block_mv.patch5.46 KB

Dries: I assume you committed this originally due to having less code in the main block.module. This patch moves it back so it may not be of much value anymore but I provide it here just in case.

Lessen learned, never include theme functions that are inside conditionally included files.

dvessel’s picture

dvessel commented
Status: Active » Needs review
StatusFileSize
new tplify_block_mv_0.patch5.46 KB

Dries: I assume you committed this originally due to having less code in the main block.module. This patch moves it back so it may not be of much value anymore but I provide it here just in case.

Lessen learned, never include theme functions that are inside conditionally included files.

dvessel’s picture

dvessel commented
StatusFileSize
new tplify_block_mv_1.patch5.46 KB

Dries: I assume you committed this originally due to having less code in the main block.module. This patch moves it back so it may not be of much value anymore but I provide it here just in case.

Lesson learned, never include theme functions that are inside conditionally included files.

dries’s picture

dries commented
Status: Needs review » Fixed

Committed to CVS HEAD. Thanks.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)
dvessel’s picture

dvessel commented
Priority: Critical » Minor
Status: Closed (fixed) » Reviewed & tested by the community

Reopening this due to a minor api change to help in these conditions. Code moved back to block.admin.inc and set a "file" for the registry.

dvessel’s picture

dvessel commented
StatusFileSize
new mv_admin_block.patch5.75 KB

the patch..

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks. (Btw, did we properly document that API change in the documentation?)

dvessel’s picture

dvessel commented

Not yet, it'll be changed in both the theme, and module dev guide.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)