The message after translation says: 'The translation for [node title] is finished and can now be reviewed'.

For usability it would be good to link the word 'reviewed' to the actual review page.

For clarity it would be useful to expand the message to: 'The translation for [node title] to [language] ........'.

CommentFileSizeAuthor
#4 improved-needs-review-message-1600478-4.patch10.69 KBberdir
#2 improved-needs-review-message.patch2.01 KBberdir

Comments

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Active
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review
StatusFileSize
new improved-needs-review-message.patch2.01 KB

What about this?

I also added a check for the case when a translator is set to auto-approve that we don't display a needs review message.

Will probably result in some test failures...

Status: Needs review » Needs work

The last submitted patch, improved-needs-review-message.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review
StatusFileSize
new improved-needs-review-message-1600478-4.patch10.69 KB

Fixed the test failures.

cgalli’s picture

cgalli commented
Status: Needs review » Reviewed & tested by the community

Applied patch, looks very good. Messages now lead you to understand which item is concerned.

We may want to look at the jobs list next. It now consists of many items with the same 'title'. The differentiation is much more difficult as a job is not one specific item but can be a bundle of all sorts of things.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Fixed

There is a in issue for the job title problem, agreed that it's currently bad. Commited.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.