"Add another location from node view page" not working

This patch fixes the checkbox not appropriately displaying as checked when saved as such. However it appears as if there's still no "add another" form generated on the node view page. That should be opened as a new issue if you're still seeking this functionality.

Instead of creating a new issue I've revamped this patch to fix the feature completely; updated title and issue summary.

Cheers!

Changed priority to critical since the issue renders location_addanother unusable and is without workaround

Well, it is not critical. I agree that it is major, but it doesn't brake a site.

Re-rolled patch from #2 with some additional commenting and code cleanup

It looks like the testbots are having some issues. Will probably have to wait for https://www.drupal.org/node/2375345 to clear up before re-testing

The tests for this patch are getting held up from a failed test on the Location module (https://qa.drupal.org/pifr/test/290218) due to #2375345: Dependency on core module results in PHP Fatal error: Cannot redeclare system_requirements(). Somehow those tests need to be rerun.

1. +++ b/contrib/location_addanother/location_addanother.module
   @@ -10,11 +10,21 @@
   +  // and the user has access to edit the node
   

   add fullstop please

2. +++ b/contrib/location_addanother/location_addanother.module
   @@ -29,12 +39,15 @@ function location_addanother_node_view($node, $view_mode) {
   +  // Load the content type's location settings to see if addanother is enabled
   

   fullstop

3. +++ b/contrib/location_addanother/location_addanother.module
   @@ -73,14 +85,20 @@ function location_addanother_form($form, &$form_state, &$node) {
   +  // Load the stored node from form_state
   

   fullstop

4. +++ b/contrib/location_addanother/location_addanother.module
   @@ -73,14 +85,20 @@ function location_addanother_form($form, &$form_state, &$node) {
   +  // Load the content type's location settings to see if addanother is enabled
   

   fullstop again

5. +++ b/contrib/location_addanother/location_addanother.module
   @@ -73,14 +85,20 @@ function location_addanother_form($form, &$form_state, &$node) {
   +  // or the user doesn't have access to add a location
   

   fullstop

6. +++ b/contrib/location_addanother/location_addanother.module
   @@ -73,14 +85,20 @@ function location_addanother_form($form, &$form_state, &$node) {
   +    count($node->locations) >= variable_get('location_maxnum_' . $node->type, 0) ||
   

   You have to add varible removing to hook_uninstall()

#7 needs work

Added fullstops and added variable removing to hook_uninstall()

#21 commited
Thanks!