t('Click sort column') can have different meaning and need to be clear.
It could mean:
- You should click on the sort column
- The clickable sort column itself
Hope this explain the problem.
$form['click_sort_column'] = array(
'#type' => 'select',
'#title' => t('Click sort column'),
'#options' => drupal_map_assoc($column_names),
'#default_value' => $this->options['click_sort_column'],
'#description' => t('Used by Style: Table to determine the actual column to click sort the field on. The default is usually fine.'),
'#fieldset' => 'more',
);
How should the field named better?
Comments
Comment #1
hass commentedComment #2
hass commented'Column used for click sorting' ?
Comment #3
dawehnerThis string sounds fine, though you have to say whether it is a problem to change strings during the stable release.
Comment #4
hass commentedOk, I will attach a patch asap.
The issue of different meaning cannot solved on translators side and out-weights the one string change. Since we have localization server and l10n_update - all string changes in stable releases are absolutely no problem. It was only a be a blocker with past days PO files inside the module release downloads.
Comment #5
hass commentedPatch attached.
Comment #6
dawehnerPatch looked fine, so committed to 7.x-3.x and 8.x-3.x
Comment #7.0
(not verified) commenteda