This Documentation oversight breaks IDE auto-completion, which makes me sad.

CommentFileSizeAuthor
#9 9-add_return_doc_for_startTransaction-1602112.patch480 bytesryan.ryan
#3 add_return_doc_for_startTransaction-1602112.patch554 bytesbgano

Comments

Paul Simard’s picture

Paul Simard commented
Issue tags: +Documentation

-documantation +documentation

bgano’s picture

bgano commented
Assigned: Unassigned » bgano
bgano’s picture

bgano commented
Status: Active » Needs review
StatusFileSize
new add_return_doc_for_startTransaction-1602112.patch554 bytes

This might make you happy.

Crell’s picture

Crell commented
Status: Needs review » Reviewed & tested by the community

Happy Crell is happy.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Component: database system » documentation

Switching components so this is on jhogdgon's radar. Way to go on your first core patch, bgano! :)

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Issue tags: -Documentation

OK, I'll get it committed when I've determined it doesn't conflict with any of the "Avoid commit conflicts" patches. Thanks!

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Version: 8.x-dev » 7.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

I don't see a conflict, so I committed this to 8.x.

It looks like it could use a port to D7:
http://api.drupal.org/api/drupal/includes!database!database.inc/function...

Crell’s picture

Crell commented

Agreed, this should be an easy backport. bgano, up for doubling your commit count? :-)

ryan.ryan’s picture

ryan.ryan commented
StatusFileSize
new 9-add_return_doc_for_startTransaction-1602112.patch480 bytes

Here's the backport :).

ryan.ryan’s picture

ryan.ryan commented
Status: Patch (to be ported) » Needs review
Crell’s picture

Crell commented
Status: Needs review » Reviewed & tested by the community

Hooray!

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Thanks! It's committed to 7.x.

Automatically closed -- issue fixed for 2 weeks with no activity.