Drupal: 5.1
Views: 5.x-1.6
Views Bookmark: 5.x-1.2
Browser: Firefox 2, Safari 2

I have a table view where one of the columns is "Bookmark: Ops for planner". views_bookmark.js isn't being added to $scripts when the view is loaded or when the node is viewed. From reading the module code it would appear that this should happen automatically?

I can supply a copy of the view code if required, but I haven't right away in case I'm missing something obvious.

Comments

merlinofchaos’s picture

merlinofchaos commented

Just to eliminate it as a problem, what theme are you using? I've found that a lot of themes that were converted from 4.7 to 5 have inadvertantly not put <?php print $scripts ?> in the <head> section as they are supposed to, which can cause module created javascript to not appear.

garrettc’s picture

garrettc commented

It's a custom theme that I've built for a client. print $scripts is in the head of page.tpl.php and the script tags for drupal.js and jquery.js are printing out fine. Just seems to be the views_bookmark javascript that's gone awol.

merlinofchaos’s picture

merlinofchaos commented

You know, I suspect the .js just isn't being added on the operations field; I'm only sure it was being added on the _links. quicksketch should be able to sort it.

garrettc’s picture

garrettc commented

It took me a second to realise quicksketch was a nick and not a module *:)

I've done a bit more digging and according to devel.module's function reference views_bookmark_add_js() is getting called when the view is loaded, just not adding anything to $scripts. That's as far as I've got though. If there's anything more specific I can do to help diagnose just let me know.

We have a staging area, so if needs be you can have a look at the running version.

quicksketch’s picture

quicksketch
he/him
commented
Status: Active » Fixed

I've committed a new version of the module which supports adding the javascript behavior to the operations field. Please reopen if the issue is not corrected in the 5.x development version. Thanks!

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)