For some reason, the user profile tab says "N/A" in it instead of "Subscriptions" now.

CommentFileSizeAuthor
#12 subscriptions.fix_menu_translation.1603644.9.patch2.61 KBsalvis
tab_error_20120527.png13.14 KBgregarios

Comments

karing’s picture

karing
Location 🇨🇦
commented

I installed the new 6.x-1.5 version (dd May 27 2012) and I'm seeing the correct menu name for the tab "Subscriptions".

What version did you upgrade from? Can you go back and forth and reproduce this? Did you run updatedb? Have you tried to Rebuild Menus?

karing’s picture

karing
Location 🇨🇦
commented

Hold on - I just managed to reproduce what you're seeing. Checking the checkbox on:

/admin/settings/subscriptions/userdefaults/settings
check to - Hide the Overview page from your users
results in a title "N/A" for the tab on /user/%/subscriptions

I have tried but I can not reproduce this in the 6.x-1.4+17-dev version. We will have to investigate further.

gregarios’s picture

gregarios commented

I upgraded from the last dev version. I ran the database update, but it didn't update anything. Cleared all caches. No Effect.

In the subscriptions.module file, on line number 150, if you change:
'title' => 'N/A', to 'title' => 'Subscriptions',
it then works correctly.

The only other place "N/A" is found in any of the module's files is a few lines before this occurrence. Maybe it was changed inadvertently?

It only happens when the option to not show the Overview settings to users is checked.

karing’s picture

karing
Location 🇨🇦
commented

So you can confirm that all was well in the 6.x-1.4+17-dev version?

gregarios’s picture

gregarios commented

So you can confirm that all was well in the 6.x-1.4+17-dev version?

Absolutely. I helped add additional functionality to it. ;-)

karing’s picture

karing
Location 🇨🇦
commented

Doh... of course you did! Sorry - still rather new here - learning usernames.

I see the N/A in the line you refer to - but if I run a diff between the dev version and this 1.5 version it looks like that bit of code also already existed in the -dev version, but for some reason we now end up there.

We'll have to ask salvis. Hopefully we've helped things along a bit to help solve this one.

gregarios’s picture

gregarios commented

It is possible it changed in 6.x-1.4+16-dev and I didn't catch it because the cache wasn't fully cleared at that time. Or something else might be making it come to the surface now...

salvis’s picture

salvis
he/his
commented
StatusFileSize
new subscriptions.fix_menu_translation.1603644.9.patch2.61 KB

Thank you both for the quick report and the analysis. It happened in Fix some minor translation issues. I was trying to fix the warnings on l.d.o, obviously with the wrong cure. This wasn't only cosmetics, the messages did point to an actual problem — it was actually broken on multi-language sites. That part of the fix is OK, but making the messages go away requires the dummy strings, just not where I originally thought.

Please try this patch.

gregarios’s picture

gregarios commented
Status: Active » Reviewed & tested by the community

The patch fixes it for me.

salvis’s picture

salvis
he/his
commented
Status: Reviewed & tested by the community » Fixed

Pushed to the -dev versions D6 and D7.

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.