I configured Commerce Multicurrency according to Commerce Guys' Module Tuesday and it seems to work until you go to checkout cart. It then sends the converted amount to Paypal but paypal still thinks it's in Dollars. So something that is $25 and I select ZAR unit, it changes to R196 (South African Rands). When I go to checkout, it takes me to the paypal website and paypal thinks I need to be charged $196 and not R196...

Please help

CommentFileSizeAuthor
#1 commerce_paypal-add-amount-conversion-for-unsupported-currencies-1603788-1.patch1.31 KBdas-peter

Comments

das-peter’s picture

das-peter commented
Title: It doesn't send which currency I'm using to Paypal » PayPal WPS - amount isn't converted if unsupported currency is used.
Project: Commerce Multicurrency » Commerce PayPal
Version: 7.x-1.1 » 7.x-1.x-dev
Component: Code » PayPal WPS
Status: Active » Needs review
StatusFileSize
new commerce_paypal-add-amount-conversion-for-unsupported-currencies-1603788-1.patch1.31 KB

I'd say this is a Commerce PayPal issue.
Because of the lack of information I can only guess that you use the Commerce PayPal WPS module, which doesn't convert the amount if an unsupported currency is used, it only changes the currency code to the one set as default in the settings.

Attached patch should fix that - but I didn't really test it.

hmartens’s picture

hmartens commented

Hi Peter

Thanks for the feedback. I'm a bit scared to incorporated this patch on a live server ;) I'll have to set up a test server first to test it on. But thanks in the meantime for taking the time to respond and write a patch.

I really appreciate it and will definitely look at this patch!

andyg5000’s picture

andyg5000
Primary language English
Location North Carolina, USA
commented

Same issue in WPP #1431464: Add “Use order currency (multi-currency support)” – option includes option to on/off conversion feature in settings. Whichever route is taken should be consistent across WPP/WPS.

rszrama’s picture

rszrama commented
Status: Needs review » Closed (duplicate)

I've committed the other approach with some changes and made it operate the same between WPP / WPS.

fwiw, PayPal doesn't support South African Rands, so with the patch I've just committed, it should be converting those prices back to $25 for payment at PayPal.

hmartens’s picture

hmartens commented

Thank you so much Ryan! You are a star, a rockstar!

abelwang’s picture

abelwang commented

can somebody post the whole commerce_paypal_wps.module after patched? its so difficult to learn to patch a file. thank you!!!

rszrama’s picture

rszrama commented

You just need to update to 7.x-2.x. There shouldn't be any issues there.

hmartens’s picture

hmartens commented

Hi Ryan

I'm running the latest Commerce Paypal version and I see what you mean, it displays the dollar (or default currency) there regardless of what currency the customer selected. It's the safest way to do it I guess...gets around the "unsupported currency" issue ;) I'm just not to sure the customers will like it displaying dollars because they wil think their creditcard doesn't support dollar...

But for me it's fine...I've asked my client if they're ok with it (not that they have a choice :) )

morad7’s picture

morad7 commented
Issue summary: View changes

does this patch work fo Paypal EC too?