Allow theme engine to register theme variable functions.

The issue with "template_preprocess_node" being registered twice was fixed with this patch for cleaning the default page.tpl.php. An unlikely place. http://drupal.org/node/163723

Theme specific preprocess variable functions still don't work. Tried with Garland.. page, node, profile_block..

I'll look more into registering preprocess functions even without a template, but it looks like it might be a little bit difficult, due to when discovery of that is actually made.

If it ends up being too troublesome, maybe try for D7? It's not critical or anything. I think in most cases, editing variables would lead to altering the template itself.

Another issue I found with trying to convert search.module to templates is that theming forms is completely broke or I missed something completely. The existing theme functions for forms aren't even being used so I'm stuck with that. The issue is waiting here: http://drupal.org/node/164032

It looks like there's another problem with that. Setting up a default "template_preprocess_search_theme_form" function and registering it still prevents it from being called.

I checked the registry and it's present but wherever it's being calling has to change too.

On top of that, forms use drupal_render(). Multiple preprocess functions don't seem to fit well with it. Which one does the rendering? template_preprocess or the theme trying to override it.?

bah, never mind about how it's called. There's a bug:

function search_forms() {
  $forms['search_theme_form']= array(
    'callback' => 'search_box',
    'callback arguments' => array('search_theme_form'),
  );
  $forms['search_block_form']= array(
    'callback' => 'search_box',
    'callback arguments' => array('search_block_form'),
  );
  return $forms;
}


function search_box(&$form_state, $form_id) {
  // Use search_keys instead of keys to avoid ID conflicts with the search block.
  $form[$form_id .'_keys'] = array(
    '#type' => 'textfield',
    '#size' => 15,
    '#default_value' => '',
    '#attributes' => array('title' => t('Enter the terms you wish to search for.')),
  );
  $form['submit'] = array('#type' => 'submit', '#value' => t('Search'));
  // Always go to the search page since the search form is not guaranteed to be
  // on every page.
  $form['#action'] = url('search/node');
  $form['#submit'][] = 'search_box_form_submit';
  $form['#validate'][] = 'search_box_form_validate';
  $form['#theme'] = 'search_box_form';

  return $form;
}

callback arguments don't match.

Sorry to bring this up so late, I'm just realizing this now after working wit hit.

Marking as critical due to this issue:

Firstly, creating a new theme specific variables function doesn't get picked up. I tried with "garland_preprocess_page()". Cleared registry and it still won't see it.

Also placed a separate issue for the search form. http://drupal.org/node/164351

Here's another one.

Inside drupal_discover_template(), path_to_theme() points into the modules folder if the variable function that suggests the template is inside the module folder.

This doesn't happen with suggestions from 'page' or 'node'. Only difference being that they are inside includes/theme.inc.

That had nothing to do with the registry. Made a separate issue here. http://drupal.org/node/165343

This is for the issue I mentioned in #6.

_theme_process_registry creates both engine and *theme* specific variable functions.

More appropriate title.

This only works when a template file exists inside the folder. Merlinofchaos informed me that without the template in the themes folder, it makes it difficult to discover but that's not critical.

Here it is..

This really needs to be reviewed. Without it, themers will have to do more work to register these manually.

Uh, I mean commited. :)

Not sure how I didn't catch this. It was working fine before but with all the changes in HEAD, it's causing a bunch of duplicate preprocess functions causing doubles of each region.

The way the array was setup just kept building up duplicates. Sorry bout that.