Closed (fixed)
Project:
Drush
Component:
Make
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
28 May 2012 at 10:08 UTC
Updated:
29 Jun 2012 at 20:41 UTC
There is one 'make' test that fails on windows:
1) makeMakefileCase::testMakeRecursion
Unexpected exit code: C:\Users\Smoker\prj\acquia\drush\drush.bat --nocolor make "C:\\Users\\Smoker\\prj\\acquia\\drush\\tests\\makefiles\\recursion.make" --no-core --contrib-destination=profiles/drupal_forum --test --md5=print
Failed asserting that 1 matches expected 0.
C:\Users\Smoker\prj\acquia\drush\tests\drush_testcase.inc:314
C:\Users\Smoker\prj\acquia\drush\tests\drush_testcase.inc:381
C:\Users\Smoker\prj\acquia\drush\tests\makeTest.php:36
C:\Users\Smoker\prj\acquia\drush\tests\makeTest.php:70
C:\Users\Smoker\prj\acquia\drush\tests\runner.php:25
I found that it is caused by the pm-download command that tries to download a file to non-existing location so I added a mkdir command that tries to create destination folder first and thus prevents realpath() from returning false on this path.
Not sure that it is a correct solution so please review.
Thanks
| Comment | File | Size | Author |
|---|---|---|---|
| download.patch | 519 bytes | dmitry_bezer |
Comments
Comment #1
moshe weitzman commentedComment #2
jhedstromLooks good to me. Tests continue to pass. Committed in b61d163.