Bugs in epublish_nodeapi and epublish_form_alter functions
| Project: | E-Publish |
| Version: | 5.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
I've noticed a couple of bugs in the 5.x module. One is in the "view" case of the epublish_nodeapi function. In page views, the module is supposed to call theme_epublish_navigation, which changes the breadcrumbing and adds some navigation links at the bottom of the page (similar to the navigation links that appear at the bottom of book pages). However, the test being used to determine whether an epublish-related node is being displayed as a page view currently says "if (!$a3)" (which means, "is not a teaser"), rather than "if ($a4)" which is the correct way to test for page view. The result produces some inappropriate changes in breadcrumbing when epublish-related nodes are listed in Drupal search results.
The other bug, in the epublish_form_alter function, makes it impossible to turn the "abstract" feature on or off for individual node types.
I'm attaching a patch that should fix both issues.
| Attachment | Size |
|---|---|
| patch_153.txt | 2.18 KB |
#1
Here's a revised patch. There was a typo in the original.
#2
#3
I know this patch has been ready to be committed for awhile but I have been happily running it. I added an additional access level to your patched version to control who can write an abstract. I found this useful for some internal intranet sites where the content in the site is re-used and/or highlighted in a monthly newsletter. I attached the additional patch on top of your submission below.
#4
http://drupal.org/node/268312
#5
Automatically closed -- issue fixed for two weeks with no activity.