upgrading form 6.x-2.12 to 6.x-2.26, I realized that the count of the table columns stopped working, so instead of the correct <table class="views-table cols-1"> I always got <table class="views-table cols-7">. Comparing /views/theme/theme.inc on both versions, I found this change:

404 $vars['class'] .= ' cols-'. count($vars['rows']);
to
414 $vars['class'] .= ' cols-' . count($vars['header']);

Changing back to rows, it's working again. Now I wonder if it's save to revert that line, what was the reasoning behind that change, if it's a bug or a feature? Is this affecting other parts that I don't know of? If not, can this fix be commited?

CommentFileSizeAuthor
#2 views-table-class-1604732.patch475 bytesheliogabal

Comments

dawehner’s picture

Status: Needs review » Needs work

Please post a patch, it's so much easier to really see whats going on then.

heliogabal’s picture

StatusFileSize
new475 bytes

sorry, I'm quite new to properly help in the issue queue and not a programmer... I hope the attached path is correctly done.

mustanggb’s picture

Issue summary: View changes
Status: Needs work » Closed (won't fix)