Hi,

The function _get_facebook_locale() fails silently if there is no ssl transport enabled in PHP. The dropdowns for locale selections are empty and it sets to en_US default.

This could be solved by falling back to http or having locales xml file included with the module as a fallback. Also, you could show a warning message.

Thank you for your work and your time.

CommentFileSizeAuthor
#6 fb_social-n1605920-6-6_1.patch1.13 KBdamienmckenna
#5 fb_social-n1605920-4-6_2.patch1.09 KBdamienmckenna
#3 fb_social-n1605920-3.patch1.09 KBdamienmckenna
#2 fb_social-add-openssl-to-requirements-1605920.patch875 bytesbarraponto

Comments

barraponto’s picture

barraponto
he / him
commented

It's not silent, actually. What happens is that it fails once, showing warnings, then caches the empty result :/

barraponto’s picture

barraponto
he / him
commented
Status: Active » Needs review
StatusFileSize
new fb_social-add-openssl-to-requirements-1605920.patch875 bytes

Added to hook requirements (as a warning that will let it continue installation).

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue summary: View changes
Status: Needs review » Needs work
StatusFileSize
new fb_social-n1605920-3.patch1.09 KB

Some slight tidying up of the code, to make it a little easier to read.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 7.x-2.x-dev » 6.x-2.x-dev
StatusFileSize
new fb_social-n1605920-4-6_2.patch1.09 KB

A version of the patch for the 6.x-2.x branch.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new fb_social-n1605920-6-6_1.patch1.13 KB

A version of the patch for the 6.x-1.x branch.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 6.x-2.x-dev » 7.x-2.x-dev

Changing back to the 7.x-2.x branch where the reviews should be done first.