I am getting a warning:
Notice: Trying to get property of non-object in workbench_moderation_states_next() (line 1441 of /home/xxxxxxx/public_html/sites/all/modules/workbench_moderation/workbench_moderation.module).
when ever I open the moderation tab

Comments

barraponto’s picture

Project: Workbench » Workbench Moderation

I guess this is a workbench moderation issue.

spouilly’s picture

The error appears because the function expects a node object in $node, but $node contains a content type instead (so the function is being called with the wrong arguments).

A little bit of troubleshooting seems to indicate that it is related to the 'workbench moderation notes' module (if you remove the module, the warning will go away).

S.

barraponto’s picture

Project: Workbench Moderation » Workbench Moderation Notes
Version: 7.x-1.1 » 7.x-1.x-dev

Let's keep the report moving.

pkil’s picture

I'm not sure how to create patches. If you change line 93 in workbench_moderation_notes.pages.inc to the following, it fixes this issue.

$next_states = workbench_moderation_states_next(workbench_moderation_state_published(), $user, $node);

Obviously just changing $node->type to reference the actual object and not the 'type' property.

barraponto’s picture

Status: Active » Needs review
StatusFileSize
new1.18 KB

Ok, let's give it a try.

pkil’s picture

Perfect, confirming #5 works.

betoscopio’s picture

Issue summary: View changes

Applied patch #5, it works.

betoscopio’s picture

Status: Needs review » Reviewed & tested by the community

Changing status, the patch seems to fix the problem.

bceyssens’s picture

Patch #5 works just fine, why hasn't this been committed yet?

cmanalansan’s picture

RTBC +1

chrisdarke’s picture

RTBC +2