I have this issue for now - JSON output after second click on the send button inside iframed webform, this may happen if you didn't fill required fields.
And another issue, if you will open then close then again open popup window, all ID's in your webform elements will be different.
e.g. before first close of popup window we have: edit-submitted-test, after closing and opening: edit-submitted-test--2

Tried both Colorbox Node version (dev and normal 2.0), same problems.

Also I tried 1.0 ver, and of course webform didn't work with it (send button return page with loaded form), but at least this URL loads – http://[SERVER_NAME]/colorbox/[patch]?width=530&height=695" if I manually put it in browser URL field. With last version of module if you trying to go to this URL you will see JSON wall.

Hope for your help.
PS Anyway it's a very usefull module, keep up with good work.
PSS I attached JSON exmaple.

CommentFileSizeAuthor
#5 ajaxsubmitloseshandler-1606712-5.patch590 bytesiLLin
new.png244.96 KBdalerr

Comments

iLLin’s picture

iLLin commented

I have noticed this if you are not logged in. Can you login and see if the same issue happens?

dalerr’s picture

dalerr commented

Hm, I have this issue for both authorized and anonymous users.
If I should provide more info just ask me.

dalerr’s picture

dalerr commented

any news on this?

iLLin’s picture

iLLin commented

Haven't had time to track it. I think its something with the session or cacheing, as it works for me when I am logged in, but if I logout it doesn't. You say it never works no matter if your logged in or not. I can duplicate it, I just need to get time to track it.

iLLin’s picture

iLLin commented
StatusFileSize
new ajaxsubmitloseshandler-1606712-5.patch590 bytes

OK, I think I have it tracked. It seems that the issue was due to multiple forms on the page (such as the login block). Once you submitted in the first time, it reattached to the wrong submit button and therefore caused it to not use ajax and return a page with JSON. Please try the attached patch, it is against the latest DEV.

iLLin’s picture

iLLin commented
Version: 7.x-2.0 » 7.x-2.x-dev
Status: Active » Needs review
dalerr’s picture

dalerr commented

Ok, i tried it, apply patch on latest dev, and in works! Woohoo! ty for that.

But, 2 prob is still here: when you open popup webform, then close it, then again open it, all classes inside form elements will change itself. Like this: edit-submitted-email → edit-submitted-email--1, if you close popup and open it again, it will be like this: edit-submitted-email--2 and so on, refreshing page will refresh id counter to zero again.

If it is any chance to fix it, this module will be the best "ready" option for popup webforms on drupal 7.

PS should I create new issue for that?

dalerr’s picture

dalerr commented

Another little issue on latest dev, when I tried to run update.php

Notice: Undefined index: colorbox_node_webform in function colorbox_node_form_alter() (line 137 in /***/modules/colorbox_node/colorbox_node.module).

iLLin’s picture

iLLin commented

The undefined index should be fixed in the latest DEV along with a few other small issues.

The classes do not change, it's the ID's that change and that's Drupals' built in counter. I would hate to reset that as there could be other forms on the page and this could cause issues. Your best bet is to target the classes instead of the ID's.

You can read further here:
http://api.drupal.org/api/drupal/includes%21common.inc/function/drupal_h...

iLLin’s picture

iLLin commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.