Entity base path is too deep [#1607028]

The base path of 'admin/structure/panels/entity/view/%fieldable_panels_panes' occupies 6 segments out of the maximum menu link depth of 9, which makes if difficult to build menu items on top of (for instance, to provide support for translatable panel panes).

http://api.drupal.org/api/drupal/includes!menu.inc/constant/MENU_MAX_DEPTH/7

In the provided patch I'm replacing "admin/structure/panels/entity/view/%fieldable_panels_panes" with 'fieldable-panels-panes/%fieldable_panels_panes', as well as implementing hook_admin_paths() to preserve its administrative nature. An update hook is also provided to flush the menu caches.

Comment	File	Size	Author
#5	shorter-paths-1607028-5.patch	26.91 KB	helior
#4	shorter-paths-1607028-4.patch	24.93 KB	helior
#3	shorter-paths-1607028-3.patch	24.99 KB	helior
#2	shorter-paths-1607028-2.patch	24.87 KB	helior
#1	base-path-1607028-1.patch	18.83 KB	helior

Comments

Comment #1

helior commented 30 May 2012 at 04:41

Status:

Active

» Needs review

Status	File	Size
new	base-path-1607028-1.patch	18.83 KB

Comment #1.0

helior commented 4 June 2012 at 05:02

Issue summary:

View changes

Updated issue summary.

Comment #2

helior commented 7 June 2012 at 18:59

Status	File	Size
new	shorter-paths-1607028-2.patch	24.87 KB

Here is an iteration that I'm much more comfortable with. I'm only bringing the menu link depth down by 1, which is just barely enough for some wiggle room ;) The most prominent change you'll notice is that the "Entities" tab was renamed to "Fieldable Panels Panes" and is now available directly under admin/structure.

Since the path isn't removed from the admin/* path, hook_admin_paths() won't be necessary anymore. Also, it's important to note that this update was made because we want to maintain the breadcrumbs, which is the only way to easily navigate back to the bundle admin pages.