install script doesnt create tables (or throw error) for mysql 4
drupalxykon - July 20, 2007 - 12:18
| Project: | Salesforce |
| Version: | 4.7.x-1.0 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Jump to:
Description
The module doesn't install the tables required. Having looked at
your install script, it appears that you only create tables for
mysqli, not generic mysql instances. Why is that?
#1
Yes, indeed, there is no reason for that. Will accept patch, or will change to the more generic mysql. Also need to support psgr
#2
In comment #1 I erroneously agree that in the install script I "only create tables for mysqli"...
However, this is not the case.
1. I cannot reproduce this error (tables are created fine in fresh installs).
2. The install script is quite standard:
switch ($GLOBALS['db_type']) {case 'mysql':
case 'mysqli':
$users_table = db_query("CREATE TABLE {salesforce_users} (
uid int(11) NOT NULL default '0',
lead_id tinytext NOT NULL,
contact_id tinytext NOT NULL,
opp_id tinytext NOT NULL,
account_id tinytext NOT NULL,
created timestamp NOT NULL default CURRENT_TIMESTAMP on update CURRENT_TIMESTAMP,
PRIMARY KEY (uid)
) ENGINE=MyISAM DEFAULT CHARSET=utf8");
So, marking as fixed.
#3
Automatically closed -- issue fixed for two weeks with no activity.