replace all the drupal_add_js calls with a single add_library call.

CommentFileSizeAuthor
#4 0001-Issue-1608510-by-ericduran-changing-add_css-to-be-ad.patch1.35 KBericduran
#3 0001-Issue-1608510-by-ericduran-small-docs-fixes.patch974 bytesericduran
#1 0001-Issue-1608510-by-ericduran-Fixed-Remove-all-drupal_a.patch4.17 KBericduran

Comments

ericduran’s picture

ericduran commented
Status: Active » Needs review
StatusFileSize
new 0001-Issue-1608510-by-ericduran-Fixed-Remove-all-drupal_a.patch4.17 KB
blakehall’s picture

blakehall commented
Status: Needs review » Reviewed & tested by the community

Works here.

ericduran’s picture

ericduran commented
StatusFileSize
new 0001-Issue-1608510-by-ericduran-small-docs-fixes.patch974 bytes

I screwed up some docs. Here's another patch on top of this one.

ericduran’s picture

ericduran commented
StatusFileSize
new 0001-Issue-1608510-by-ericduran-changing-add_css-to-be-ad.patch1.35 KB

Moves the css out of the library, because apparently it still works with out any of the JS

levialliance’s picture

levialliance commented

The 3rd parameter of drupal_add_library(), $every_page can be TRUE since variable_get('nice_menus_js', 1) is a global setting.

xiukun.zhou’s picture

xiukun.zhou commented
Status: Reviewed & tested by the community » Fixed

Thanks a lot to ericduran, levialliance and everyone else for the great work on the patches, testing, reviews and reporting.

It's more time this got committed and I went ahead and had this rolled at: 7.x-2.x: b17c01b.

Marking this as fixed.

Please let me know if you would have any other questions, comments, issues or concerns on any of these changes, I would be glad to provide more information.
Thanks again to everyne for the help and great work on this issue.

Cheers!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.