The signup admin form should display a pager when there are more than 25 events, however the pager doesn't appear.

Versions:
Drupal 5.x-dev (2007-Jul-19)
Apache/2.0.54
PHP 4.3.10-22
MySQL 4.1.11

And duplicate site on a different server:
Drupal 5.x-dev (2007-Jul-19)
Apache/2.2.3
PHP 5.0.41
MySQL 5.2.0-10

I've tried both in my custom theme and with Garland, so I don't think it's theme related.

Steps to repeat:
Have more than 25 signup enabled events.
Visit http://example.com/admin/content/signup
Scroll to the bottom of the page and note the absence of the pager.

CommentFileSizeAuthor
#3 signup_admin_pager-v1.patch653 bytesadrinux

Comments

dww’s picture

dww
we/he/they
commented
Status: Active » Closed (works as designed)

Nope, there's no code in signup.module trying to make a pager out of the table at node/X/signups, so there's no bug.

If you want to turn this issue into a feature request to add that, you could, but keep in mind it's going to be tricky due to the fact that it's a form rendered as a table, so the usual pager-related stuff that's all tied into an SQL query isn't going to work as nicely.

dww’s picture

dww
we/he/they
commented
Status: Closed (works as designed) » Active

Ugh, sorry, I misread your post. You're talking about admin/content/signup (you even said so, doh!). ;) And yeah, there is code in there trying to make a pager query out of it. Not sure why that's not working.

adrinux’s picture

adrinux commented
Status: Active » Needs review
StatusFileSize
new signup_admin_pager-v1.patch653 bytes

I've got this working on my setup by passing a count to the pager query.

Code could definitely do with a look over by someone else though :)

Patch produced via svk diff attached.

dww’s picture

dww
we/he/they
commented
Status: Needs review » Fixed

After further review and testing, I committed a modified version of your patch to HEAD, DRUPAL-5, and DRUPAL-4-7. Thanks!

csc4’s picture

csc4 commented

Is this patch in the 5.2 version too? I'm a bit confused as to which version is the latest - looking at the modified dates seems to suggest it's 5 head, but the release notes and comments for that suggest it's 5.1?

dww’s picture

dww
we/he/they
commented

I don't know what "5.2" means. Do you mean "5.x-2.*"? If so, yes. That's what the code in HEAD is currently for. I committed the fix to all branches.

However, I see now that I forgot to put this in the CHANGELOG.txt files, which I just took care of on all branches.

Cheers,
-Derek

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)