When uploading additional images to a gallery, the position of each new image is inconsistent. Most views will do a sort first by weight, and then by node ID or created date. However, this can be problematic:

  1. Create a gallery and upload photos to it.
  2. Using the Sort Images tab, move the first image to the end of the gallery.
  3. Using the Upload tab, upload new images. Since they will be uploaded with weight = 0, they will be inserted before the last photo.
CommentFileSizeAuthor
#2 1608916.2-jquery_ui.weight.patch659 byteszengenuity
#1 1608916.1-image-weight.patch1.13 KBdeviantintegral

Comments

deviantintegral’s picture

deviantintegral commented
Status: Active » Needs review
StatusFileSize
new 1608916.1-image-weight.patch1.13 KB

Attached is a patch that always sets the weight on new image nodes. This has the effect of storing explicit ordering for photos instead of relying on the node ID.

zengenuity’s picture

zengenuity commented
Assigned: Unassigned » zengenuity
StatusFileSize
new 1608916.2-jquery_ui.weight.patch659 bytes

I think this can only happen when you have jQuery UI sorting enabled. (Can you confirm that's what you are using?) The tabledrag interface always makes the weights negative, but the jQuery UI version is using positive numbers. They should be consistent. The attached patch makes the jQuery UI interface use negative numbers like tabledrag does.

Your patch looks like it works, but I think this is a better way to fix the problem.

zengenuity’s picture

zengenuity commented
Status: Needs review » Fixed

Committed: http://drupalcode.org/project/node_gallery.git/commit/a31c34174799179bb8...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.