Operations links to edit forums and their containers leads to plain the "list" view (default). No error messages.
example.com/admin/content/forum
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | forum.module_22.patch | 1.03 KB | bdragon |
| #9 | forum.module_21.patch | 892 bytes | bdragon |
| #4 | forum.module_20.patch | 850 bytes | fwalch |
| #3 | forum.module_19.patch | 707 bytes | fwalch |
Comments
Comment #1
derjochenmeyer commentedSteps
- created a "testcontainer"
<root>- created a "testforum"
<root>- tried to edit "testforum"
Expected:
- editpage
What happend:
- link does not work.
- No editpage
Comment #2
dvessel commentedew, marking as critical.
Comment #3
fwalch commentedThe menu item to edit a forum is "admin/content/forum/edit/%forum_term". However, there is no function corresponding to this placeholder. The attached patch adds a "forum_term_load" function to forum.module, which fixes the bugs.
You have to re-enable the forum module to make the changes effective.
Comment #4
fwalch commentedI just noticed that I didn't create the last patch correctly... here's a new one.
Comment #5
dvessel commentedYou have to cvs diff from root. The changes do work but i have no clue on how it's doing it? Nothing calls "forum_term_load" directly. Is that part of a hook?
I think it should be documented a bit more. I'd do it myself but I don't understand it.
Comment #6
bdragon commentedWorks perfectly and looks OK.
My only comment is that I don't see any documentation on some of the other _load functions (example: aggregator_feed_load) -- Is there a convention for marking functions as being there to provide menu placeholders?
Comment #7
bdragon commentedOK, two comments on the documentation block, heh.
Back to CNW.
Comment #8
bdragon commentedI looked at all the other _loads in core and the documentation block isn't wildly different than some of them.
I withdraw my comment about the documentation block.
However, dvessel pointed out in IRC that the patch needs to be rolled from the root.
Comment #9
bdragon commentedRerolled from root.
Comment #10
dvessel commentedI briefly chatted with bdragon in IRC. He mentioned that these types of functions aren't really documented much. I guess your expected to understand the menu system to know what's going on here.
Patch applies cleanly and does its job.
Comment #11
gábor hojtsyIsn't there a term loading function already? This does not seem like containing anything special for forum terms in menu paths, so I think we could easily get away with using/reusing the term loading in taxonomy module, if there is any. I did not check.
Comment #12
bdragon commentedYou reminded me of something with your question.
The function should return FALSE when the tid is not part of the forum vocabulary.
CNWing, followup patch in a sec.
Comment #13
bdragon commentedOK, this one will return page not found if you attempt to put in a tid that is not part of the forum vocabulary.
Comment #14
gábor hojtsyWell, *this* looked logical, thanks! Committed!
Comment #15
(not verified) commented