The styling for follow buttons on d.o issues is way to generic and needs to be specific to the flag machine name.

CommentFileSizeAuthor
#8 flag-links.patch1.07 KBtvn
#6 1611886_flag_links_more_specific_style.patch1.01 KBgreggles
dontstyle_all_flag_links.png8.06 KBgreggles
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rupl’s picture

rupl
he/him
Primary language English
CreditAttribution: rupl commented

Are these links available only to d.o admins? I am not familiar with those links. As Greg mentioned, changing all of the current a.flag selectors to a.flag-project-issue-follow should limit the styling to "Follow" flags at the top of the sidebar on issue queue pages.

tvn’s picture

tvn CreditAttribution: tvn commented

These links should be on g.d.o somewhere, since it's where we have Mollom. I've asked Greg to check if the issue is still there and give us some example url.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented

I now enabled a flag for all comments to help debugging this.

tvn’s picture

tvn CreditAttribution: tvn commented
Status: Active » Postponed

Postponing this till D7 d.o actually has follow button.

tvn’s picture

tvn CreditAttribution: tvn commented
Status: Postponed » Closed (duplicate)

D7 d.o now has follow button. Theming happens at #1828652: Theme the "Follow" button in the issue metadata block, closing this one as duplicate.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented
Status: Closed (duplicate) » Needs review
FileSize
1611886_flag_links_more_specific_style.patch1.01 KB

We're now using this flag on g.d.o, so it would be nice to get this added to the 6.x branch.

I'm least confident about this change:

-a.unflag-action {
+.flag-project-issue-follow a.unflag-action {
tvn’s picture

tvn CreditAttribution: tvn commented
Assigned: Unassigned » tvn
Status: Needs review » Needs work

The patch in #6 needs some corrections, I'll upload new one later today.

tvn’s picture

tvn CreditAttribution: tvn commented
Status: Needs work » Needs review
FileSize
flag-links.patch1.07 KB

Patch attached.
Applied to d.o dev site: http://tvn-drupal.redesign.devdrupal.org/node/1793956
and g.d.o dev site: http://events-groups.redesign.devdrupal.org/node/243443

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented

I don't seem to have the right credentials for those and am unsure where to "drush uli" them, but if it looks remotely right I'm sure it is.

Thanks for the help tvn! Can you commit/deploy this on g.d.o? I can do the deploy part but I don't think I can commit to bluecheese.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented

tvn hooked me up with some passwords. I can now confirm that indeed this looks perfect. Thanks!

sreynen’s picture

sreynen CreditAttribution: sreynen commented
Status: Needs review » Reviewed & tested by the community

Patch looks good to me and #10 sounds like RTBC.

rupl’s picture

rupl
he/him
Primary language English
CreditAttribution: rupl commented

Pinging @drumm because I don't have ability to commit to D6 bluecheese.

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm commented
Status: Reviewed & tested by the community » Fixed

Committed & being deployed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.