Code refactoring. Moving configuration form code into superfish.admin.inc

Greetings,

While doing refactoring for our Drupal project we found a few things in Superfish that we want to help you with. I will be sending a few feature requests. Every my request is tested by me.

The first one is a code optimization.

1. I suggest to move: superfish_block_configure(), superfish_block_save(), superfish_form_block_admin_configure_alter() and superfish_block_validate() into superfish.admin.inc since this code is not needed on 99% of site pages. During site life cycle block configuration is almost never changed, so no need to load it in memory on each page load.
To have it working you need to implement this event in superfish.module:

/**
 * Implements hook_hook_info().
 */
function superfish_hook_info() {
  $hooks = array(
    'block_configure' => array(
      'group' => 'admin',
    ),
    'block_save' => array(
      'group' => 'admin',
    ),
    'form_block_admin_configure_alter' => array(
      'group' => 'admin',
    ),
  );
  return $hooks;
}

This change reduce the sise of superfish.module almost twice!

2. There is no need to check required fields for empty values on your own validation function. You can use '#required' => TRUE instead when building a form. This is a standard validation. All other checks are fine.

3. And a small one... no need to do explicit return in superfish_block_save().

Please find two patches attached to this issue.

Thank you for your work on this module and hope to participate in its development and support since our company is interested in using this module on all future sites!