Results say '0 comments' when comment.module is disabled [#1612530]

Comment	File	Size	Author
#8	1612530-8.patch	4.17 KB	nick_vh
#7	1612530-7.patch	1.74 KB	nick_vh
#6	1612530-6.patch	880 bytes	nick_vh
#5	0comments-1612530-4.patch	953 bytes	willmoy

Comment #1

he/him

Ghent

commented 1 June 2012 at 12:38

This is the bad code!

  if (isset($node->last_comment_timestamp) && !empty($node->comment_count)) {
    $document->ds_last_comment_timestamp = apachesolr_date_iso($node->last_comment_timestamp);
    $document->ds_last_comment_or_change = apachesolr_date_iso(max($node->last_comment_timestamp, $node->changed));
  }
  else {
    $document->ds_last_comment_or_change = apachesolr_date_iso($node->changed);
  }
  $document->is_comment_count = isset($node->comment_count) ? $node->comment_count : 0;

Is there a way to easily see if a node can have comments or not?

Log in or register to post comments

Comment #3

willmoy commented 1 June 2012 at 14:11

Thanks for the quick response!

From node_schema:

'comment' => array(
        'description' => 'Whether comments are allowed on this node: 0 = no, 1 = closed (read only), 2 = open (read/write).',
        'type' => 'int',
        'not null' => TRUE,
        'default' => 0,
      ),

That becomes $node->comment

So if $node->comment == 0;
a comment count shouldn't be displayed.

I suggest also that if $node->comment == 1 and there are no comments, it shouldn't be displayed (because probably comments have always been turned off and displaying 0 comments in that case would be unhelpful).

Log in or register to post comments

Comment #4

nick_vh

he/him

Ghent

commented 11 June 2012 at 18:28

Category:

bug

» feature

Marking as feature request, not critical for now. Hopefully someone can provide us with a patch

Log in or register to post comments

Comment #5

willmoy commented 12 June 2012 at 11:28

Status	File	Size
new	0comments-1612530-4.patch	953 bytes

Well, I can provide a patch (which I think is trival). I've attached it. The problem is I can't test it because we don't run dev, the test suite won't run on the version we have installed, and I don't have a test installation. But here it is for what it's worth!

I defer to you, but I think it is a bug to say something has 0 comments when comments aren't even enable on the site (even if not a very important one) — but the way the markup is you can't hide just the comments bit with CSS.