I have two content types. One is to be moderated using workbench_access (Article) in order to let groups of assigned users become editors and the other (Image) is to be moderated by site staff only. When an Image is created, it is set to go into the "Needs Review" state. After enabling workbench_access, the Image content disappears from the needs-review tab (even when viewing as uid 1). Images still show up for moderation in the preview of the workbench_moderation view. They just don't show on the actual needs-review tab. Disabling workbench_access makes them show up again.
How can I get the Image content type to show up on the needs-review tab while using workbench_access?
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | wa_node_list-1613604-4.patch | 3.11 KB | ericaordinary |
| #4 | interdiff.txt | 812 bytes | ericaordinary |
| #1 | 1613604-wa-node-list.patch | 3.09 KB | agentrickard |
Comments
Comment #1
agentrickardHm. I'm not sure this is actually possible.
This was introduced along with #1082220: Configure Workbench Access by Content Type. Here's the problem:
We need to filter the View by a nodes that meet the condition:
* In the list of nids that are assigned to the selected access schemes.
* OR of a node type not governed by our access controls.
Now, I can make Views do this, but is it actually the correct behavior? The patch mitigates this by only showing "untracked" node types if you do not select a section filter. This seems right to me.
Comment #2
Sborsody commentedThanks for the quick response and patch!
I applied this patch to test. It is showing all "needs review" nodes, both ones assigned to a section and ones that are not, when no section filter is selected. The "My Drafts" tab also shows all nodes.
Is there any way to add a "None" option to the section filter like how there's an -Any- option on the type filter? It would make more sense for users than trying to deselect an option from the multi-select list (on my browser I have to hold down CTRL and click on the option I want to deselect).
Comment #3
agentrickardIt would, but doing so may force a lot of changes to the existing code. Care to try a separate patch for that?
While the current UX isn't ideal, it's enough to push forward.
Comment #4
ericaordinary commentedThis patch was not working for the list at admin/workbench/content/all
The check to ensure the node table is present was returning false when it was already present, so I've attached an updated version of the patch that fixes it on my installation.
Comment #5
agentrickardI think this is related to / duplicate of #1439418: Sections exposed filter on view acts as though relationship is required but the patch here looks more complete.
Comment #6
ericaordinary commentedI also noticed that this patch doesn't fix the block displays on the workbench dashboard, but it does fix the "view all" pages, so the users can at least access all their content through those links.
Comment #7
agentrickardPatch no longer applies.
Comment #8
agentrickardThis was fixed by #1897454: My Edits views are broken when not all content types are under Workbench Access