og2list My Subscription (og_manage_form) broken with og for 5.x, og_uid_global support missing

Users who have values of NULL in their og_uid.mail_type field will be defaulting to not getting emails (web only).

The previous patch incorrectly displayed "individual mail" selected on the form for these users, when it should default to web only so they have to choose individual messages or digest and turn it on.

attached _0 patch is updated to reflect this.

I think the submit button has to be printed because otherwise it vanishes for groups that don't have mailing lists set.

The problematic part is that og2list is doing this form altering on og subscription form. Instead of just changing things, og2list is removing the submit button from, and it was happening for groups without mailing lists enabled. If you enable og2list on a site with lots of existing groups then suddenly no one can manage their subscription settings.

Anyway it's been a while, I will have to look at it in the HEAD version again.. I found a fairly compelling reason not to have the submit button printed and I think that was it.

You should try making a group without a list and then checking my subscription, see if you can still modify them. I'll be getting a HEAD version up for testing in the next little bit, and I'll review it again as well. If the current group has a mailing list I guess we could keep removing that submit button, as long as it doesn't affect other groups. The user is actually submitting a form, it just contains the one hidden form element. Maybe other modules might want to inject or alter the form and add/remove stuff too? That is another argument for keeping the submit.

Yes it works with the module disabled but what about when the module is enabled, for groups without a mailing list?

try this:

1. disable og2list
2. Create a new group.
3. subscribe to notifications for it - note the appearance of the subscription page
4. Now re-enable og2list in admin/build/modules
5. go to the group you created (without a mailing list) and back to your my subscription page

see if is showing the submit button. If the submit button is blocked, but the group doesn't have a list, then that's a bug.. I think this is the behaviour I was seeing.

I don't think og2list should be touching og's form at all... at least definitely not for groups that don't have a recipient set in thier edit form (ie non og2list groups but with og2list enabled).

I have created a public test environment for og2list HEAD current issues - please see http://groups.drupal.org/node/9392 for more info on the test instances.

This is the first patch that we will be testing. The patch is not applied to http://og2list-b4.postcarbon.org (that version is HEAD).
The patch IS applied to http://og2list-after.postcarbon.org (that is HEAD http://drupal.org/files/issues/og2list_manage_subscription_fixes_0.patch from #1 on this issue)

We are verifying two main problems/fixes here.

1. Register on http://og2list-b4.postcarbon.org.

2. Visit and subscribe to these two test groups:
testgroup-b4 (og2list group) http://og2list-b4.postcarbon.org/testgroup-b4
non-og2list (non og2list group) http://og2list-b4.postcarbon.org/non-og2list

3. Go into "My Account" on og2list-b4 and set Organic Groups -> Notification Settings to be:
Selectively send email notification based on the checkbox for each of my group's My Subscription page

4. Log in to http://og2list-after.postcarbon.org with the same username and password from Step 1 (we use LDAP integration to join all our site logins together).

5. Join the two corresponding test groups on og2list-after:
testgroup-after (og2list group) http://og2list-after.postcarbon.org/testgroup-after
non-og2list (non og2list group) http://og2list-after.postcarbon.org/non-og2list

6. Go into "My Account" on og2list-after and set Organic Groups -> Notification Settings to be:
Selectively send email notification based on the checkbox for each of my group's My Subscription page

7. Now see how the My Subscription behaves differently in an og2list group when set to selective notifications
- on og2list-b4, go into testgroup-b4 and choose "my subscription" on the right.
The options will appear but there is no way to submit them! og2list is removing the Submit button!
- on og2list-after, the submit button is there and the form works as expected.

8. See how My Subscription behaves differently when set to always or never receive notifications:
- go into my account, and set Organic Groups Settings -> Email Notification to "Always receive notifications"
- Now go to og2list-b4 and choose "My subscription". Event hough you are set to always receive notifications, you will see the three options. But there is no submit button! og2list should be saying you are set to always and showing a link to the profile page.
- On og2list-after, set yourself to Always Receive Notifications in my account and then go to og2list-after and hit "My subscription". You should see a message that you are set to always accept notifications, a link to your profile page, and no submit button.

7. See how My Subscription behaves differently for a non-og2list group
- on og2list-b4, go into "non-og2list' group and choose "my subscription". You will see that instead of the og subscription options, og2list is replacing the form with:

Mail address: n/a
No mailing list has been created for this group.

This makes no sense, as the group should show normal options if it's not configured for a mailing list, not remove the og options and print that!

- on og2list-after, go into "non-og2list" and choose "My Subscription" on the right. You will see the normal og subscription options.

Please test along and verify this is indeed broken on og2list-b4 and working on og2list-after!

8. The mail-out improvements make the Always / Never settings in og_uid_global correctly override these settings. You can test that too:
- Create a second account on the og2list-b4 site with an e-mail you'll receive
- Sign up to testgroup-b4
- Hit "My account" and set yourself to always receive notifications
- Repeat the process on testgroup-after - log in with the 2nd account (using LDAP), sign up to testgroup-after, and then go into My Account and set yourself to always receive notifications.
- Now log out of both sites and log in with the original usernames (also subscribed to the testgroups)
- Use og2list to e-mail in, or the group menu on the right to create new content in the two test groups.
- In og2list-b4, you should not receive an og2list mail. mail-out.pl won't properly see your new user and its og_uid_global setting
- in og2list-after, you should receive an og2list mail, becuase mail-out.pl sees the og_uid_global row.
- Note that on both test sites, you should receive double notifications - og and og2list. This is because http://drupal.org/node/165299 is not yet applied (we are going to work on testing that one next)

9. Test that "My subscription" on og2list-after shows the mail address your mail has to come from.
It should look like this:

From-Address for messages: user@example.com
You must use the e-mail address shown here to send messages. If your e-mails to the list bounce, make sure you are sending them from this address!

Please let me know here or at http://groups.drupal.org/node/9392 if you find any problems with the test environments. And if you do help test, please comment back here so your testing is recorded (that will greatly help get the patches reviewed and ready for CVS).

OK, some problems were found testing the last patch.

A couple of the changes weren't applied becuase it was for 1.106 and head is 1.109.

I re-rolled it to the right version. I also got a testing report back that og2list was incorrectly showing the submit button when it shouldn't, as reported and patched by miglius in #3.

It turns out if you are an admin, you see the subscription options in HEAD when you shouldn't, and then no submit is shown. This is the behavior I was originally noticing because I was using an admin user. For regular users, the The correct behaviour is as with #3 patched, so admins also get the message that they are set to always or never and a link to their profile page.

For regular users, the bug was as follows:
- when set to always or never in my account, regular users would see the 3 options and no submit button.
- Instead it should behave the same as og and print that they were set to always or never and have the link.

I updated the testing instructions at #8 so they properly reflect as it will look for regular users. I also verified that the forms are working correctly with an admin user, and applied the new version of the patch to og2list-after.

If someone can go through the test instructions again (#8) and comment back that would be helpful!